reductionista commented on a change in pull request #505:
URL: https://github.com/apache/madlib/pull/505#discussion_r457784779
##########
File path: src/ports/postgres/modules/dbscan/dbscan.py_in
##########
@@ -235,6 +726,10 @@ def _validate_dbscan(schema_madlib, source_table,
output_table, id_column,
fn_dist_list = ['dist_norm1', 'dist_norm2', 'squared_dist_norm2',
'dist_angle', 'dist_tanimoto']
_assert(metric in fn_dist_list, "dbscan Error: metric has to be one of the
madlib defined distance functions")
Review comment:
Or maybe just list them here. As long as the user doesn't have to
search through the user guide for them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
