reductionista commented on a change in pull request #525:
URL: https://github.com/apache/madlib/pull/525#discussion_r556079234
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -520,21 +544,35 @@ def fit_transition(state, dependent_var, independent_var,
dependent_var_shape,
and only gets cleared in eval transition at the last row of the last
iteration.
"""
- if not independent_var or not dependent_var:
+ if not dependent_var_shape:
Review comment:
Re: checking dependent_var vs dependent_var_shape, I don't have a strong
preference. I think I went with that out of a habit for avoiding messing with
any potentially large data structures in favor of small ones, if all we need is
a boolean. But I don't think it actually matters in this case--if you like
dependent_var better I can change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
