reductionista commented on a change in pull request #525:
URL: https://github.com/apache/madlib/pull/525#discussion_r556085247
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -520,21 +544,35 @@ def fit_transition(state, dependent_var, independent_var,
dependent_var_shape,
and only gets cleared in eval transition at the last row of the last
iteration.
"""
- if not independent_var or not dependent_var:
+ if not dependent_var_shape:
Review comment:
Maybe the safest would be to check all 4 of them? If any one of them is
NULL but another of the 3 is non-NULL then that's a sign that there's something
seriously wrong and we should probably just stop and error out immediately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
