kaknikhil commented on a change in pull request #534:
URL: https://github.com/apache/madlib/pull/534#discussion_r583867354
##########
File path:
src/ports/postgres/modules/deep_learning/madlib_keras_model_selection.sql_in
##########
@@ -288,7 +302,7 @@ load_model_selection_table(
so we first create a model architecture table with two different models. Use
Keras to define
a model architecture with 1 hidden layer:
<pre class="example">
-import keras
+from tensorflow import keras
Review comment:
Just to be more explicit, we should use tensorflow.keras in the next two
lines as well
##########
File path:
src/ports/postgres/modules/deep_learning/madlib_keras_fit_multiple_model.sql_in
##########
@@ -879,7 +914,7 @@ num_classes | 3
-# Define and load model architecture. Use Keras to define
the model architecture with 1 hidden layer:
<pre class="example">
-import keras
+from tensorflow import keras
Review comment:
Just to be more explicit, we should use tensorflow.keras in the next two
lines as well
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_automl.sql_in
##########
@@ -900,7 +923,7 @@ num_classes | 3
-# Define and load model architecture. Use Keras to define
the model architecture with 1 hidden layer:
<pre class="example">
-import keras
+from tensorflow import keras
Review comment:
Just to be more explicit, we should use tensorflow.keras in the next two
lines as well
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.sql_in
##########
@@ -996,22 +1041,24 @@ SELECT madlib.validation_preprocessor_dl('iris_test',
-- Source table
SELECT * FROM iris_test_packed_summary;
</pre>
<pre class="result">
--[ RECORD 1 ]-------+---------------------------------------------
-source_table | iris_test
-output_table | iris_test_packed
-dependent_varname | class_text
-independent_varname | attributes
-dependent_vartype | character varying
-class_values | {Iris-setosa,Iris-versicolor,Iris-virginica}
-buffer_size | 15
-normalizing_const | 1.0
-num_classes | 3
+-[ RECORD 1 ]-----------+---------------------------------------------
+source_table | iris_test
+output_table | iris_test_packed
+dependent_varname | {class_text}
+independent_varname | {attributes}
+dependent_vartype | {"character varying"}
+class_text_class_values | {Iris-setosa,Iris-versicolor,Iris-virginica}
+buffer_size | 10
+normalizing_const | 1
+num_classes | {3}
+distribution_rules | all_segments
+__internal_gpu_config__ | all_segments
</pre>
-# Define and load model architecture. Use Keras to define
the model architecture:
<pre class="example">
-import keras
+from tensorflow import keras
from keras.models import Sequential
Review comment:
Just to be more explicit, we should use tensorflow.keras in the next two
lines as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
