fmcquillan99 commented on a change in pull request #534:
URL: https://github.com/apache/madlib/pull/534#discussion_r583964864
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.sql_in
##########
@@ -178,6 +188,11 @@ madlib_keras_fit(
There are no mandatory parameters so
if you specify NULL, it will use all default
values as per Keras.
+
+ @note
+ Callbacks are not currently supported except for TensorBoard
Review comment:
i'd suggest we don't spend anymore time on looking at this, there may be
TF1.x vs 2.x diffs plus we plan to look at callbacks in the next release 1.19.0
in a more systematic way. So I am OK with it as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
