fmcquillan99 commented on a change in pull request #534:
URL: https://github.com/apache/madlib/pull/534#discussion_r584932875
##########
File path:
src/ports/postgres/modules/deep_learning/keras_model_arch_table.sql_in
##########
@@ -42,16 +39,25 @@ Interface and implementation are subject to change. </em>
<li class="level1"><a href="#related">Related Topics</a></li>
</ul></div>
-This utility function loads model architectures and
+This function loads model architectures and
weights into a table for use by deep learning algorithms.
+
Model architecture is in JSON form
and model weights are in the form of PostgreSQL binary data types (bytea).
If the output table already exists, a new row is inserted
into the table so it can act as a repository for multiple model
architectures and weights.
-There is also a utility function to delete a model
-from the table.
+There is also a function to delete a model from the table.
+
+MADlib's deep learning methods are designed to use the TensorFlow package and
its built in Keras
+functions. To ensure consistency, please use tensorflow.keras objects
(models, layers, etc.)
+instead of importing Keras and using its objects.
+
+Please note that the first <em>n</em> layers of the model must have the shape
Review comment:
@orhankislal ^^^ please clarify and suggest wording on this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
