khannaekta commented on a change in pull request #560:
URL: https://github.com/apache/madlib/pull/560#discussion_r591731136
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_wrapper.py_in
##########
@@ -440,16 +444,16 @@ def get_custom_functions_list(compile_params):
"""
compile_dict = convert_string_of_args_to_dict(compile_params)
- builtin_losses = dir(losses)
+ builtin_losses = update_builtin_losses(dir(losses))
builtin_metrics = update_builtin_metrics(dir(metrics))
custom_fn_list = []
local_loss = compile_dict['loss'].lower() if 'loss' in compile_dict else
None
- local_metric = compile_dict['metrics'].lower()[2:-2] if 'metrics' in
compile_dict else None
+ metric_list = ast.literal_eval(compile_dict['metrics'].lower()) if
'metrics' in compile_dict else []
Review comment:
It makes sense to catch it earlier. Yes, I think we should add the
similar try/catch for better error msg.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
