reductionista commented on a change in pull request #571:
URL: https://github.com/apache/madlib/pull/571#discussion_r710630754
##########
File path: tool/jenkins/jenkins_build.sh
##########
@@ -60,9 +60,9 @@ sleep 15
echo "---------- Install pip, and mock -----------"
# cmake, make, make install, and make package
cat <<EOF
-docker exec madlib bash -c 'apt-get update; apt-get install -y python-pip; pip
install mock' | tee $workdir/logs/madlib_compile.log
+docker exec madlib bash -c 'apt-get update; apt-get install -y python-pip; pip
install mock scipy==1.2.1' | tee $workdir/logs/madlib_compile.log
EOF
-docker exec madlib bash -c 'apt-get update; apt-get install -y python-pip; pip
install mock' | tee $workdir/logs/madlib_compile.log
+docker exec madlib bash -c 'apt-get update; apt-get install -y python-pip; pip
install mock scipy==1.2.1' | tee $workdir/logs/madlib_compile.log
Review comment:
I hadn't noticed there was still an import for `scipy` in the DBSCAN
module. That was used in an earlier version, but now we are using
`np.linalg.norm` to compute distances instead. I've removed the dependency
from DBSCAN, but we should keep this change in jenkins since knn does import
`scipy`--not sure how it was working before.
Thanks for this and the gpdb5 port--great to see it working on all platforms
now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@madlib.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
