khannaekta commented on a change in pull request #571:
URL: https://github.com/apache/madlib/pull/571#discussion_r723780636
##########
File path: tool/jenkins/jenkins_build.sh
##########
@@ -60,9 +60,9 @@ sleep 15
echo "---------- Install pip, and mock -----------"
# cmake, make, make install, and make package
cat <<EOF
-docker exec madlib bash -c 'apt-get update; apt-get install -y python-pip; pip
install mock' | tee $workdir/logs/madlib_compile.log
+docker exec madlib bash -c 'apt-get update; apt-get install -y python-pip; pip
install mock scipy==1.2.1' | tee $workdir/logs/madlib_compile.log
EOF
-docker exec madlib bash -c 'apt-get update; apt-get install -y python-pip; pip
install mock' | tee $workdir/logs/madlib_compile.log
+docker exec madlib bash -c 'apt-get update; apt-get install -y python-pip; pip
install mock scipy==1.2.1' | tee $workdir/logs/madlib_compile.log
Review comment:
Actually knn doesn't use `scipy` it either. The import that you saw in
[knn.sql_in](https://github.com/apache/madlib/blob/master/src/ports/postgres/modules/knn/knn.sql_in#L528)
is actually part of an example in docs. That's why it was working fine (I got
confused for a moment).
Let's remove it from here then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
