zhangwenchao-123 commented on PR #627: URL: https://github.com/apache/madlib/pull/627#issuecomment-3430306044
> ❌ What's Missing (Critical Issues) > > ``` > 1. No main CMakeLists.txt for Cloudberry: > - src/ports/cloudberry/CMakeLists.txt doesn't exist > - This file should mirror the structure of > src/ports/greenplum/CMakeLists.txt (13KB, ~300 lines) > - Should define: port configuration, source files, SQL handling, > build functions, and version management > > 2. Not integrated into the build system: > - src/ports/CMakeLists.txt only contains: > add_subdirectory(postgres) > add_subdirectory(greenplum) > - Missing: add_subdirectory(cloudberry) > 3. No CloudberryUtils.cmake: > - Greenplum has GreenplumUtils.cmake with utility functions > - May need similar utilities for Cloudberry-specific features > ``` > > 🔍 Current State > > ``` > CMake configuration completed but: > - Cloudberry was NOT detected (the FindCloudberry code was never executed) > - Only PostgreSQL and Greenplum detection ran > - Build directory shows only postgres/ and greenplum/ subdirectories > > However, there IS a Cloudberry installation: > - Location: /usr/local/cloudberry/ > - Version: Based on PostgreSQL 14.4 with GP_VERSION_NUM 30000 (Cloudberry v3.0.0) > - This matches the src/ports/cloudberry/3/ directory structure > ``` > > 📊 Summary > > ``` > The Cloudberry port is partially implemented. The detection logic and > version-specific configs exist, but they're not wired into the build > system. > > To complete the implementation, you would need: > > 1. Create src/ports/cloudberry/CMakeLists.txt (modeled after Greenplum's) > 2. Add add_subdirectory(cloudberry) to src/ports/CMakeLists.txt > 3. Potentially create CloudberryUtils.cmake for Cloudberry-specific features > 4. Test the full build process with Cloudberry detection > ``` Have fixed all mentioned problems and license lose -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
