edespino commented on code in PR #627:
URL: https://github.com/apache/madlib/pull/627#discussion_r2454282801
##########
src/madpack/utilities.py:
##########
@@ -189,6 +189,8 @@ def get_dbver(con_args, portid):
# for Greenplum the 3rd digit is necessary to differentiate
# 4.3.5+ from versions < 4.3.5
match = re.search("Greenplum[a-zA-Z\s]*(\d+\.\d+\.\d+)",
versionStr)
+ elif portid == 'cloudberry':
+ match = re.search("Cloudberry[a-zA-Z\s]*(\d+\.\d+\.\d+)",
versionStr)
Review Comment:
`"Cloudberry[a-zA-Z\s]*(\d+\.\d+\.\d+)"` should be `"Apache
Cloudberry[a-zA-Z\s]*(\d+\.\d+\.\d+)"` ?
I am not entirely sure about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
