Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/48#discussion_r68996034
--- Diff: src/ports/postgres/modules/svm/svm.py_in ---
@@ -676,27 +985,32 @@ def svm_help(schema_madlib, message, is_svc,
**kwargs):
def svm(schema_madlib, source_table, model_table,
dependent_varname, independent_varname, kernel_func,
kernel_params, grouping_col, params, is_svc,
- verbose, detect_novelty=False, **kwargs):
+ verbose, add_intercept=False, **kwargs):
--- End diff --
`fit_intercept` has been added to `kernel_params`. We can still keep the
`array[1, ...]` usage for non-kernel case since we anyways need that in other
modules. The add_intercept here is only to override the user-provided param.
I'll change this to use `add_intercept=None` and add a note to make it clearer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
