Github user mktal commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/48#discussion_r69005568
--- Diff: src/ports/postgres/modules/svm/svm.py_in ---
@@ -676,27 +985,32 @@ def svm_help(schema_madlib, message, is_svc,
**kwargs):
def svm(schema_madlib, source_table, model_table,
dependent_varname, independent_varname, kernel_func,
kernel_params, grouping_col, params, is_svc,
- verbose, detect_novelty=False, **kwargs):
+ verbose, add_intercept=False, **kwargs):
--- End diff --
I agree that it is probably ok for now that we discourage the use of
`array[1, ...]` only in the kernel case and ask users to specify
`fit_intercept` in the kernel params. We will also need to add notes in the doc
to make it clear to the users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
