Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/154#discussion_r129798317
--- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
@@ -84,11 +85,11 @@ def pagerank(schema_madlib, vertex_table, vertex_id,
edge_table, edge_args,
edge_params = extract_keyvalue_params(edge_args, params_types,
default_args)
# populate default values for optional params if null
- if damping_factor is None:
+ if (damping_factor is None) or (damping_factor == ''):
damping_factor = 0.85
- if max_iter is None:
+ if (max_iter is None) or (max_iter == ''):
--- End diff --
Why are `max_iter` and `damping_factor` strings?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
