Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/154#discussion_r129797208
--- Diff: src/ports/postgres/modules/graph/apsp.py_in ---
@@ -72,22 +73,25 @@ def graph_apsp(schema_madlib, vertex_table, vertex_id,
edge_table,
edge_params = extract_keyvalue_params(edge_args, params_types,
default_args)
# Prepare the input for recording in the summary table
- if vertex_id is None:
+ if (vertex_id is None) or (vertex_id == ''):
v_st = "NULL"
vertex_id = "id"
else:
v_st = vertex_id
- if edge_args is None:
+
+ if (edge_args is None) or (edge_args == ''):
e_st = "NULL"
else:
e_st = edge_args
- if grouping_cols is None:
+
+ if (grouping_cols is None) or (grouping_cols == ''):
g_st = "NULL"
glist = None
else:
g_st = grouping_cols
glist = split_quoted_delimited_str(grouping_cols)
+
--- End diff --
Don't need the extra line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
