[ 
https://issues.apache.org/jira/browse/MAHOUT-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003635#comment-13003635
 ] 

Alexander Hans commented on MAHOUT-531:
---------------------------------------

I finally got around to look at this again and first did a `svn up'. It seems 
like this issue has been resolved by a commit Ted did for MAHOUT-545. The 
problem of getting the actual number of values set is solved by writing each 
row of the matrix as a vector. Vectors have getNumNondefaultElements() and 
iterateNonZero(), so there's no need to implement it (differently) for 
matrices. My patch is pretty much obsolete then, only the test is still useful, 
since Ted hasn't implemented a MatrixWritableTest yet, as it seems. Also, 
apparently Ted's MatrixWritable doesn't support labels yet. I will make a new 
patch fixing the labels and containing the test.

> MatrixWritable doesn't actually write/read anything
> ---------------------------------------------------
>
>                 Key: MAHOUT-531
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-531
>             Project: Mahout
>          Issue Type: Bug
>          Components: Math
>    Affects Versions: 0.4
>            Reporter: Alexander Hans
>            Assignee: Sean Owen
>             Fix For: 0.5
>
>         Attachments: MAHOUT-531.patch, MAHOUT-531.patch
>
>
> The write() and readFields() methods of MatrixWritable write/read only the 
> classname, they don't write/read actual data.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to