[
https://issues.apache.org/jira/browse/MAHOUT-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133866#comment-13133866
]
Sean Owen commented on MAHOUT-838:
----------------------------------
OK, better. Now we're to small items. Javadoc must start with /** or it isn't
javadoc. Always put braces on conditionals. Why are you making all the Maps
into LinkedHashMap? I don't see a reason to order by access time. I see stanzas
like:
String cmPath = params.get("confusionMatrix");
cmPath = "/tmp";
This can't be right can it -- are there still remanants of debugging code?
likewise I see lines like "object.hashCode();" which are no-ops.
You have a comment about using AbstractJob methods -- yes, can this be done
upfront?
What's the purpose of PrintConfusionMatrix? it seems like the other two new
Dumper classes fulfill the role outlined in this JIRA.
> Make the confusion matrix writable to a file when testing classifiers
> ---------------------------------------------------------------------
>
> Key: MAHOUT-838
> URL: https://issues.apache.org/jira/browse/MAHOUT-838
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.6
> Reporter: Grant Ingersoll
> Priority: Minor
> Attachments: ConfusionMatrix.java, MAHOUT-838.patch,
> MAHOUT-838.patch, MAHOUT-838_mini.patch, MatrixWritable.java, bayes-cm-10.html
>
>
> If you have a lot of labels for a classifier, the confusion matrix is hard to
> fit in terminal window. Would be nice if we could write it out to a file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
