[
https://issues.apache.org/jira/browse/MAHOUT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149034#comment-13149034
]
Sean Owen commented on MAHOUT-881:
----------------------------------
-1 Grant I thought we discussed this on the mailing list? I don't see that this
achieves anything. You are still doing an implicit n log n heap sort to attain
an ordered result. You still allocate a container object for the result. This
seems like swapping some code for more complex (but equally working) code, and
adding a Lucene dependency.
Do you have a load test that shows it would be notably faster? the patch does
have such a thing.
The comment about SimilarUser is right though. It would just affect tie
breaking, which doesn't really matter, but should be fixed.
> Refactor TopItems to use Lucene's PriorityQueue and remove excessive sorting
> ----------------------------------------------------------------------------
>
> Key: MAHOUT-881
> URL: https://issues.apache.org/jira/browse/MAHOUT-881
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.6
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Attachments: MAHOUT-881.patch
>
>
> TopItems.getTop*() all do a fair number of excessive operations that can be
> replaced by switching to using Lucene's PriorityQueue implementation, which
> is more efficient and faster than Java's built in PQ implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
