+1 Am 12.04.2013 18:17 schrieb "Robin Anil" <robin.a...@gmail.com>:
> +1 to both the new methods and extending Guava functions > > Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc. > > > On Fri, Apr 12, 2013 at 6:55 AM, Dan Filimon <dangeorge.fili...@gmail.com > >wrote: > > > I'm adding interfaces for DoubleDoubleFunctions with the following > special > > properties: > > f(x, 0) = x for any x > > f(0, y) = 0 for any y > > so that we can speed up sparse vector operations in these cases [1]. > > > > Doing this, I'm also updating the existing functions in Functions.java to > > support the new interfaces where appropriate. > > > > I'm seeing some functions use the PlusMult class (subtraction notably) > and > > there seem to be lots of unused functions. > > Also, these functions don't implement Guava's Function interface making > > interfacing with Guava difficult in new code. > > > > Is this just a case of this being older less cleaned-up code, or are > there > > reasons for this design? > > If it's the former, would anyone be willing to have a look and do some > > refactoring? Or, maybe add this as a started issue for GSOC students? :) > > > > [1] https://issues.apache.org/jira/browse/MAHOUT-1190 > > >
