[
https://issues.apache.org/jira/browse/MAHOUT-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031613#comment-14031613
]
ASF GitHub Bot commented on MAHOUT-1464:
----------------------------------------
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/mahout/pull/18#discussion_r13781773
--- Diff: math/src/main/java/org/apache/mahout/math/function/Functions.java
---
@@ -1393,6 +1393,17 @@ public double apply(double a) {
};
}
+ /** Constructs a function that returns <tt>a != b ? 1 : 0</tt>.
<tt>a</tt> is a variable, <tt>b</tt> is fixed. */
+ public static DoubleFunction notEqual(final double b) {
+ return new DoubleFunction() {
+
+ @Override
+ public double apply(double a) {
+ return a != b ? 1 : 0;
--- End diff --
Whenever I modify a mature file that someone else has created, my general
rule is to stay with the style of the collective authors. Here I agree that the
1.0, 0.0 is better I'm hesitant to change it here when 1, and 0 are used
throughout the file and I don't want to change it everywhere. There is probably
more chance of me messing something up accidentally than actually fixing
something if I change the whole file. If this seem wrong let me know but in
past jobs we did this to avoid constant thrash over minor style disagreements.
> Cooccurrence Analysis on Spark
> ------------------------------
>
> Key: MAHOUT-1464
> URL: https://issues.apache.org/jira/browse/MAHOUT-1464
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Environment: hadoop, spark
> Reporter: Pat Ferrel
> Assignee: Pat Ferrel
> Fix For: 1.0
>
> Attachments: MAHOUT-1464.patch, MAHOUT-1464.patch, MAHOUT-1464.patch,
> MAHOUT-1464.patch, MAHOUT-1464.patch, MAHOUT-1464.patch, run-spark-xrsj.sh
>
>
> Create a version of Cooccurrence Analysis (RowSimilarityJob with LLR) that
> runs on Spark. This should be compatible with Mahout Spark DRM DSL so a DRM
> can be used as input.
> Ideally this would extend to cover MAHOUT-1422. This cross-cooccurrence has
> several applications including cross-action recommendations.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
