[ https://issues.apache.org/jira/browse/MAHOUT-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852604#comment-15852604 ]
ASF GitHub Bot commented on MAHOUT-1935: ---------------------------------------- GitHub user rawkintrevo opened a pull request: https://github.com/apache/mahout/pull/277 MAHOUT-1935 fix double calculation of XtX Collect XtX only once, and pass it to `solve`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rawkintrevo/mahout mahout-1935 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/mahout/pull/277.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #277 ---- commit 470a5748e34cd085bc5e89d458aa3b136de46af4 Author: rawkintrevo <trevor.d.gr...@gmail.com> Date: 2017-02-04T05:17:41Z MAHOUT-1935 fix double calculation of XtX ---- > Inefficient use of XtX calculation in Ordinary Least Squares > ------------------------------------------------------------ > > Key: MAHOUT-1935 > URL: https://issues.apache.org/jira/browse/MAHOUT-1935 > Project: Mahout > Issue Type: Improvement > Affects Versions: 0.13.0 > Reporter: Trevor Grant > Priority: Minor > Labels: beginner > Fix For: 0.13.0 > > > In line 59 of OrdinaryLeastSquaresModel we calculate and collect XtX, but > then don't bother to use it (so it is in essence calculated twice). > https://github.com/apache/zeppelin/blob/master/spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java -- This message was sent by Atlassian JIRA (v6.3.15#6346)