[ https://issues.apache.org/jira/browse/MAHOUT-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852975#comment-15852975 ]
ASF GitHub Bot commented on MAHOUT-1935: ---------------------------------------- Github user andrewpalumbo commented on the issue: https://github.com/apache/mahout/pull/277 +1.. BTW you could also compute and cache it, (if it were actually needed the first time) to avoid recalculation of `X.t %*% X` down the line. > Inefficient use of XtX calculation in Ordinary Least Squares > ------------------------------------------------------------ > > Key: MAHOUT-1935 > URL: https://issues.apache.org/jira/browse/MAHOUT-1935 > Project: Mahout > Issue Type: Improvement > Affects Versions: 0.13.0 > Reporter: Trevor Grant > Assignee: Trevor Grant > Priority: Minor > Labels: beginner > Fix For: 0.13.0 > > > In line 59 of OrdinaryLeastSquaresModel we calculate and collect XtX, but > then don't bother to use it (so it is in essence calculated twice). > ~https://github.com/apache/zeppelin/blob/master/spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java~ > Not sure how that link got in there. It is unrelated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)