[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995463#comment-15995463
 ] 

ASF GitHub Bot commented on MAHOUT-1962:
----------------------------------------

Github user rawkintrevo commented on a diff in the pull request:

    https://github.com/apache/mahout/pull/300#discussion_r114629177
  
    --- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/tests/FittnessTests.scala
 ---
    @@ -47,10 +52,44 @@ object FittnessTests {
     
       // https://en.wikipedia.org/wiki/Mean_squared_error
       def MeanSquareError[R[K] <: RegressorModel[K], K](model: R[K], 
residuals: DrmLike[K]): R[K] = {
    +    // TODO : I think mse denom should be (row - col) ??
    --- End diff --
    
    you may be right, why do you think this?


> Add F-test to Linear Regression  Fitness Tests
> ----------------------------------------------
>
>                 Key: MAHOUT-1962
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1962
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Algorithms
>    Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>            Reporter: Dustin VanStee
>            Priority: Minor
>              Labels: beginner
>             Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to