[
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995536#comment-15995536
]
ASF GitHub Bot commented on MAHOUT-1962:
----------------------------------------
Github user rawkintrevo commented on a diff in the pull request:
https://github.com/apache/mahout/pull/300#discussion_r114638847
--- Diff:
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/RegressorModel.scala
---
@@ -30,6 +30,9 @@ trait RegressorModel[K] extends SupervisedModel[K] {
// Common Applicable Tests- here only for convenience.
var mse: Double = _
var r2: Double = _
+ var fpval: Double = _
+ var rss:Double = -9999.0
--- End diff --
Sure there is a reason, but why are you initializing to -9999.0 instead of
_ ?
> Add F-test to Linear Regression Fitness Tests
> ----------------------------------------------
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
> Issue Type: Improvement
> Components: Algorithms
> Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
> Reporter: Dustin VanStee
> Priority: Minor
> Labels: beginner
> Fix For: 0.13.1
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> This update will modify
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and
> add an overall Ftest for significance of one or more parameters being not
> equal to zero.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
