[ 
https://issues.apache.org/jira/browse/CONNECTORS-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644958#comment-13644958
 ] 

Andrew Janowczyk commented on CONNECTORS-676:
---------------------------------------------

find attached a patch based on the branch.

Lots of changes based on our conversations.

1. I've implemented the path variable, which defaults to "/" (i.e. the whole 
dropbox). now you can stick absolute path's in there and it will only index 
that directory (subfolders + files).  so for example /Photos will index 
everything in photos

2. i moved the path parameter to the job specification instead of the 
connector. this seems quite logical. the connector's authorization is valid for 
all jobs, but you may want to have different folders at different levels.

3. now we add seeds which are directories only, upto a maximum of 25,000 
(highest number which dropbox supports, above that there is no way to actually 
get additional files). each directory is then read directly using the metadata 
method from the SDK instead of using the delta method. This is a huge 
improvement over what i previously had. additionally since the folder has its 
own revision information, manifold auto-magically takes care of the versioning 
resulting in much less communication overhead.  using this technique obviates 
the need for any of the other stuff we discussed above.

i checked and ran the modifications you made, using ant, and they worked 
beautifully.




                
> Connector for dropbox
> ---------------------
>
>                 Key: CONNECTORS-676
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-676
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Dropbox connector
>    Affects Versions: ManifoldCF 1.1.1
>            Reporter: Andrew Janowczyk
>            Assignee: Karl Wright
>             Fix For: ManifoldCF 1.3
>
>         Attachments: dropbox-patch.patch, dropbox-patch-v2.patch
>
>
> Pretty straight forward. It'd be nice to have a connector which can read from 
> dropbox. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to