Two in BaseITHSQLDB's setupElasticSearch method First to set the Java_HOME Map<String, String> envs = pb.environment(); if (System.getenv("JAVA_HOME")!= null) { envs.put("JAVA_HOME",System.getenv("JAVA_HOME")); } else { throw new Exception("Missing JAVA_HOME as a system environment variable"); }
The second removing the double dot if (isUnix) { pb.command("bash", "-c", "./test-materials/unix/elasticsearch-7.6.2/bin/elasticsearch -q -Expack.ml.enabled=false"); System.out.println("Unix process"); } else { pb.command("cmd.exe", "/c", "..\\test-materials\\windows\\ elasticsearch-7.6.2\\bin\\elasticsearch.bat -q -Expack.ml.enabled=false"); System.out.println("Windows process"); } =================================================================== --- connector/src/test/java/org/apache/manifoldcf/agents/output/elasticsearch/tests/BaseITHSQLDB.java (revision 1881665) +++ connector/src/test/java/org/apache/manifoldcf/agents/output/elasticsearch/tests/BaseITHSQLDB.java (working copy) @@ -32,6 +32,7 @@ import org.apache.http.util.EntityUtils; import org.apache.http.impl.client.HttpClients; import java.io.IOException; +import java.util.Map; import java.io.File; @@ -44,11 +45,13 @@ { final static boolean isUnix; + static { final String os = System.getProperty("os.name").toLowerCase(); if (os.contains("win")) { isUnix = false; } else { + //Unix isUnix = true; } } @@ -84,9 +87,16 @@ final File absFile = new File(".").getAbsoluteFile(); System.out.println("ES working directory is '"+absFile+"'"); pb.directory(absFile); + Map<String, String> envs = pb.environment(); + if (System.getenv("JAVA_HOME")!= null) { + envs.put("JAVA_HOME",System.getenv("JAVA_HOME")); + } else { + throw new Exception("Missing JAVA_HOME as a system environment variable"); + } + if (isUnix) { - pb.command("bash", "-c", "../test-materials/unix/elasticsearch-7.6.2/bin/elasticsearch -q -Expack.ml.enabled=false"); + pb.command("bash", "-c", "./test-materials/unix/elasticsearch-7.6.2/bin/elasticsearch -q -Expack.ml.enabled=false"); System.out.println("Unix process"); } else { pb.command("cmd.exe", "/c", "..\\test-materials\\windows\\elasticsearch-7.6.2\\bin\\elasticsearch.bat -q -Expack.ml.enabled=false"); @@ -93,10 +103,13 @@ System.out.println("Windows process"); } + + File log = new File("es.log"); pb.redirectErrorStream(true); pb.redirectOutput(ProcessBuilder.Redirect.appendTo(log)); esTestProcess = pb.start(); + System.out.println("ElasticSearch is starting..."); //the default port is 9200 On Sat, Sep 12, 2020 at 2:19 PM Karl Wright <daddy...@gmail.com> wrote: > What changes did you make? > Karl > > > On Sat, Sep 12, 2020 at 2:41 PM Michael Cizmar <mich...@michaelcizmar.com> > wrote: > > > Didn't reach ES; waiting... > > Didn't reach ES; waiting... > > Didn't reach ES; waiting... > > Response from ES: HTTP/1.1 200 OK > > ES came up! > > ElasticSearch is started on port 9200 > > > > @Karl - How would you like this packaged up? > > > > On Sat, Sep 12, 2020 at 12:52 PM Michael Cizmar < > mich...@michaelcizmar.com > > > > > wrote: > > > > > Agreed. We want to limit this unpacking because elastic packages them > > > differently. I started down the rabbit hole of making a macOS download > > but > > > then got into permission issues and started issuing chmod. > > > > > > When I get back from lunch I am going to just set the JDK of the > process > > > to be the system environment variable and I think that will fix the > > problem. > > > > > > On Sat, Sep 12, 2020 at 12:37 PM Karl Wright <daddy...@gmail.com> > wrote: > > > > > >> Hi Michael, > > >> > > >> > > >> > > >> JAVA_HOME is not usually a requirement for Maven building but it's not > > >> > > >> unreasonable to have it, especially since maven itself looks for it. > > >> > > >> > > >> > > >> I suspect that, in order for the Maven build to work, you currently > need > > >> to > > >> > > >> do this: > > >> > > >> - Set JAVA_HOME > > >> > > >> - Run the ant build first > > >> > > >> > > >> > > >> That's a little pain in the butt but we can fix this going forward - > at > > >> > > >> least the unpacking part. > > >> > > >> Karl > > >> > > >> > > >> > > >> > > >> > > >> On Sat, Sep 12, 2020 at 1:33 PM Michael Cizmar < > > mich...@michaelcizmar.com > > >> > > > >> > > >> wrote: > > >> > > >> > > >> > > >> > I figured it out. Just working through it. There was a path issue. > > >> When > > >> > > >> > I start the process it's looking for a JAVA_HOME. I've got that now > > >> set to > > >> > > >> > the JDK that comes with elastic. The download of elastic that ant > is > > >> > > >> > doing is specific for linx Linux so that's failing. > > >> > > >> > > > >> > > >> > Does the build require JAVA_HOME to be set? The machine I'm > working > > on > > >> > > >> > does not have that set. > > >> > > >> > > > >> > > >> > On Sat, Sep 12, 2020 at 12:27 PM Karl Wright <daddy...@gmail.com> > > >> wrote: > > >> > > >> > > > >> > > >> > > The ant build unpacks the ES binary and puts in the place needed > to > > >> run. > > >> > > >> > > My guess is that we need to add similar unpacking to the maven > pom. > > >> I'll > > >> > > >> > > see if there is a way to do that. > > >> > > >> > > Karl > > >> > > >> > > > > >> > > >> > > > > >> > > >> > > On Sat, Sep 12, 2020 at 12:00 PM Michael Cizmar < > > >> > > >> > mich...@michaelcizmar.com > > >> > > >> > > > > > >> > > >> > > wrote: > > >> > > >> > > > > >> > > >> > > > I think you are right. The es.log file contains the following: > > >> > > >> > > > > > >> > > >> > > > bash: > > ../test-materials/unix/elasticsearch-7.6.2/bin/elasticsearch: > > >> No > > >> > > >> > > such > > >> > > >> > > > file or directory > > >> > > >> > > > bash: > > ../test-materials/unix/elasticsearch-7.6.2/bin/elasticsearch: > > >> No > > >> > > >> > > such > > >> > > >> > > > file or directory > > >> > > >> > > > bash: > > ../test-materials/unix/elasticsearch-7.6.2/bin/elasticsearch: > > >> No > > >> > > >> > > such > > >> > > >> > > > file or directory > > >> > > >> > > > bash: > > ../test-materials/unix/elasticsearch-7.6.2/bin/elasticsearch: > > >> No > > >> > > >> > > such > > >> > > >> > > > file or directory > > >> > > >> > > > bash: > > ../test-materials/unix/elasticsearch-7.6.2/bin/elasticsearch: > > >> No > > >> > > >> > > such > > >> > > >> > > > file or directory > > >> > > >> > > > bash: > > ../test-materials/unix/elasticsearch-7.6.2/bin/elasticsearch: > > >> No > > >> > > >> > > such > > >> > > >> > > > file or directory > > >> > > >> > > > > > >> > > >> > > > On Sat, Sep 12, 2020 at 10:49 AM Karl Wright < > daddy...@gmail.com> > > >> > > >> > wrote: > > >> > > >> > > > > > >> > > >> > > > > Ok, I didn't realize this was from Maven only. It may be a > > >> working > > >> > > >> > > > > directory or dependency version issue. > > >> > > >> > > > > > > >> > > >> > > > > > > >> > > >> > > > > On Sat, Sep 12, 2020 at 11:37 AM Michael Cizmar < > > >> > > >> > > > mich...@michaelcizmar.com > > >> > > >> > > > > > > > >> > > >> > > > > wrote: > > >> > > >> > > > > > > >> > > >> > > > > > I reproduced the infinite Elastic Search Loop when building > > from > > >> > > >> > > maven. > > >> > > >> > > > > > I'm investigating it now. > > >> > > >> > > > > > > > >> > > >> > > > > > On Sat, Sep 12, 2020 at 9:30 AM Michael Cizmar < > > >> > > >> > > > > mich...@michaelcizmar.com> > > >> > > >> > > > > > wrote: > > >> > > >> > > > > > > > >> > > >> > > > > > > I'll take a look at the build this AM. > > >> > > >> > > > > > > > > >> > > >> > > > > > > On Sat, Sep 12, 2020 at 5:13 AM Karl Wright < > > >> daddy...@gmail.com> > > >> > > >> > > > > wrote: > > >> > > >> > > > > > > > > >> > > >> > > > > > >> Hi all, > > >> > > >> > > > > > >> > > >> > > >> > > > > > >> I don't have a Mac, so if we can't figure out how to get > ES > > >> to > > >> > > >> > > start > > >> > > >> > > > > > >> properly on a Mac, I have no ability to debug it > myself. I > > >> > > >> > would > > >> > > >> > > be > > >> > > >> > > > > > >> forced > > >> > > >> > > > > > >> to recommend we just disable the test - or continue with > > the > > >> > > >> > vote, > > >> > > >> > > > > since > > >> > > >> > > > > > >> nothing has changed and we released it this way for the > > last > > >> > > >> > > release > > >> > > >> > > > > in > > >> > > >> > > > > > >> April. We have people waiting for the Postgresql > updates. > > >> > > >> > > > > > >> > > >> > > >> > > > > > >> Karl > > >> > > >> > > > > > >> > > >> > > >> > > > > > >> > > >> > > >> > > > > > >> On Wed, Sep 9, 2020 at 11:54 AM Cihad Guzel < > > >> cguz...@gmail.com> > > >> > > >> > > > > wrote: > > >> > > >> > > > > > >> > > >> > > >> > > > > > >> > Michael, > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > I have log lines repeating like as follow: > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > ------------------------------------------------------- > > >> > > >> > > > > > >> > T E S T S > > >> > > >> > > > > > >> > ------------------------------------------------------- > > >> > > >> > > > > > >> > Running > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > >> > > >> > > > > > > > >> > > >> > > > > > >> > > >> > > > >> > > org.apache.manifoldcf.agents.output.elasticsearch.tests.APISanityHSQLDBIT > > >> > > >> > > > > > >> > Configuration file successfully read > > >> > > >> > > > > > >> > [main] INFO org.eclipse.jetty.util.log - Logging > > >> initialized > > >> > > >> > > > @7246ms > > >> > > >> > > > > > >> > [main] INFO org.eclipse.jetty.server.Server - > > >> > > >> > > > jetty-9.2.3.v20140905 > > >> > > >> > > > > > >> > [main] INFO > > >> org.eclipse.jetty.server.handler.ContextHandler - > > >> > > >> > > > > Started > > >> > > >> > > > > > >> > o.e.j.w.WebAppContext@2ad48653 > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > >> > > >> > > > > > > > >> > > >> > > > > > > >> > > >> > > > > > >> > > >> > > > > >> > > >> > > > >> > > > {/mcf-crawler-ui,file:/private/var/folders/gw/4lgs06cd065d09gnm6ythcp80000gn/T/jetty-0.0.0.0-8346-mcf-crawler-ui.war-_mcf-crawler-ui-any-5325495261063795321.dir/webapp/,AVAILABLE}{../dependency/mcf-crawler-ui.war} > > >> > > >> > > > > > >> > [main] INFO > > >> org.eclipse.jetty.server.handler.ContextHandler - > > >> > > >> > > > > Started > > >> > > >> > > > > > >> > o.e.j.w.WebAppContext@6bb4dd34 > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > >> > > >> > > > > > > > >> > > >> > > > > > > >> > > >> > > > > > >> > > >> > > > > >> > > >> > > > >> > > > {/mcf-authority-service,file:/private/var/folders/gw/4lgs06cd065d09gnm6ythcp80000gn/T/jetty-0.0.0.0-8346-mcf-authority-service.war-_mcf-authority-service-any-1339291969162319913.dir/webapp/,AVAILABLE}{../dependency/mcf-authority-service.war} > > >> > > >> > > > > > >> > [main] INFO > > >> org.eclipse.jetty.server.handler.ContextHandler - > > >> > > >> > > > > Started > > >> > > >> > > > > > >> > o.e.j.w.WebAppContext@7d9f158f > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > >> > > >> > > > > > > > >> > > >> > > > > > > >> > > >> > > > > > >> > > >> > > > > >> > > >> > > > >> > > > {/mcf-api-service,file:/private/var/folders/gw/4lgs06cd065d09gnm6ythcp80000gn/T/jetty-0.0.0.0-8346-mcf-api-service.war-_mcf-api-service-any-2172701003493912621.dir/webapp/,AVAILABLE}{../dependency/mcf-api-service.war} > > >> > > >> > > > > > >> > [main] INFO org.eclipse.jetty.server.ServerConnector - > > >> Started > > >> > > >> > > > > > >> > ServerConnector@2796aeae{HTTP/1.1}{0.0.0.0:8346} > > >> > > >> > > > > > >> > [main] INFO org.eclipse.jetty.server.Server - Started > > >> @10899ms > > >> > > >> > > > > > >> > ES working directory is > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > >> > > >> > > > > > > > >> > > >> > > > > > > >> > > >> > > > > > >> > > >> > > > > >> > > >> > > > >> > > > '/Users/cguzel/Projects/apache/svn/release-2.17-RC1/connectors/elasticsearch/target/test-output/.' > > >> > > >> > > > > > >> > Unix process > > >> > > >> > > > > > >> > ElasticSearch is starting... > > >> > > >> > > > > > >> > Didn't reach ES; waiting... > > >> > > >> > > > > > >> > Didn't reach ES; waiting... > > >> > > >> > > > > > >> > Didn't reach ES; waiting... > > >> > > >> > > > > > >> > Didn't reach ES; waiting... > > >> > > >> > > > > > >> > Didn't reach ES; waiting... > > >> > > >> > > > > > >> > Didn't reach ES; waiting... > > >> > > >> > > > > > >> > Didn't reach ES; waiting... > > >> > > >> > > > > > >> > Didn't reach ES; waiting... > > >> > > >> > > > > > >> > Didn't reach ES; waiting... > > >> > > >> > > > > > >> > Didn't reach ES; waiting... > > >> > > >> > > > > > >> > Didn't reach ES; waiting... > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > Cihad > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > Michael Cizmar <mich...@michaelcizmar.com>, 9 Eyl 2020 > > >> Çar, > > >> > > >> > > 12:40 > > >> > > >> > > > > > >> > tarihinde > > >> > > >> > > > > > >> > şunu yazdı: > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > Cihad, > > >> > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > What was the error that you received when compiling > in > > >> > > >> > maven? > > >> > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > On Wed, Sep 9, 2020 at 3:39 AM Cihad Guzel < > > >> > > >> > cguz...@gmail.com > > >> > > >> > > > > > >> > > >> > > > > > wrote: > > >> > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > > Hi Karl, > > >> > > >> > > > > > >> > > > > > >> > > >> > > > > > >> > > > I have successfully compiled using ant build. I > tried > > >> to > > >> > > >> > > > compile > > >> > > >> > > > > > the > > >> > > >> > > > > > >> > > tag[1] > > >> > > >> > > > > > >> > > > using maven, but the ElasticSearch tests still fail > > >> using > > >> > > >> > > Mac > > >> > > >> > > > > [2] > > >> > > >> > > > > > . > > >> > > >> > > > > > >> > > > < > > https://issues.apache.org/jira/browse/CONNECTORS-1651 > > >> > > > >> > > >> > > > > > >> > > > > > >> > > >> > > > > > >> > > > [1] > > >> > > >> > > > > > >> > > >> > > >> > https://svn.apache.org/repos/asf/manifoldcf/tags/release-2.17-RC1 > > >> > > >> > > > > > >> > > > [2] > > >> https://issues.apache.org/jira/browse/CONNECTORS-1651 > > >> > > >> > > > > > >> > > > > > >> > > >> > > > > > >> > > > Regards, > > >> > > >> > > > > > >> > > > Cihad Güzel > > >> > > >> > > > > > >> > > > > > >> > > >> > > > > > >> > > > > > >> > > >> > > > > > >> > > > Karl Wright <daddy...@gmail.com>, 8 Eyl 2020 Sal, > > >> 16:32 > > >> > > >> > > > > tarihinde > > >> > > >> > > > > > >> şunu > > >> > > >> > > > > > >> > > > yazdı: > > >> > > >> > > > > > >> > > > > > >> > > >> > > > > > >> > > > > Tests pass. +1 from me. > > >> > > >> > > > > > >> > > > > > > >> > > >> > > > > > >> > > > > Looking for a few other voters? > > >> > > >> > > > > > >> > > > > > > >> > > >> > > > > > >> > > > > Karl > > >> > > >> > > > > > >> > > > > > > >> > > >> > > > > > >> > > > > > > >> > > >> > > > > > >> > > > > On Sat, Sep 5, 2020 at 6:32 AM Karl Wright < > > >> > > >> > > > > daddy...@gmail.com> > > >> > > >> > > > > > >> > wrote: > > >> > > >> > > > > > >> > > > > > > >> > > >> > > > > > >> > > > > > Please vote on whether to release Apache > > ManifoldCF > > >> > > >> > > 2.17, > > >> > > >> > > > > RC1. > > >> > > >> > > > > > >> The > > >> > > >> > > > > > >> > > > > > release artifact can be found here: > > >> > > >> > > > > > >> > > > > > > > >> > > >> > > > > > >> > > > > > > > >> > > >> > > > > > >> > > > > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > >> > > >> > > > > > > > >> > > >> > > > > > >> > > >> > > > >> > > https://dist.apache.org/repos/dist/dev/manifoldcf/apache-manifoldcf-2.17 > > >> > > >> > > > > > >> > > > > > > > >> > > >> > > > > > >> > > > > > There is also a release tag at: > > >> > > >> > > > > > >> > > > > > > > >> > > >> > > > > > >> > > > > > > > >> > > >> > > > > > >> > > >> > > >> > https://svn.apache.org/repos/asf/manifoldcf/tags/release-2.17-RC1 > > >> > > >> > > > > > >> > > > > > > > >> > > >> > > > > > >> > > > > > This release does not contain anything major - > > >> just a > > >> > > >> > > few > > >> > > >> > > > > bug > > >> > > >> > > > > > >> > fixes, > > >> > > >> > > > > > >> > > > > > summarized in the CHANGES.txt file. It does > > >> include > > >> > > >> > > > > > >> documentation, > > >> > > >> > > > > > >> > > > > > however, which did not get successfully built > for > > >> the > > >> > > >> > > 2.16 > > >> > > >> > > > > > >> release. > > >> > > >> > > > > > >> > > > > Please > > >> > > >> > > > > > >> > > > > > review carefully with that in mind. > > >> > > >> > > > > > >> > > > > > > > >> > > >> > > > > > >> > > > > > The respin was required because the > ElasticSearch > > >> test > > >> > > >> > > did > > >> > > >> > > > > not > > >> > > >> > > > > > >> > > properly > > >> > > >> > > > > > >> > > > > > work on the Mac. > > >> > > >> > > > > > >> > > > > > > > >> > > >> > > > > > >> > > > > > Thanks! > > >> > > >> > > > > > >> > > > > > Karl > > >> > > >> > > > > > >> > > > > > > > >> > > >> > > > > > >> > > > > > > > >> > > >> > > > > > >> > > > > > > > >> > > >> > > > > > >> > > > > > > >> > > >> > > > > > >> > > > > > >> > > >> > > > > > >> > > > > >> > > >> > > > > > >> > > > >> > > >> > > > > > >> > > >> > > >> > > > > > > > > >> > > >> > > > > > > > >> > > >> > > > > > > >> > > >> > > > > > >> > > >> > > > > >> > > >> > > > >> > > >> > > >