Glad you were able to figure it out. I will have some time perhaps this weekend to merge a few pull requests and maybe yours can be done as well.
On Wed, Sep 27, 2023 at 11:52 AM Guylaine BASSETTE < guylaine.basse...@francelabs.com> wrote: > Hello, > > I have good news :-) > > I've been working on the ManifoldCF trunk with Zookeeper 3.8.0, and the > error in the TestZooKeeperLocks test class has changed. Both tests > failed because the ZK server wouldn't start. > > First of all, I found two missing dependencies that fix the tests, but > only when run one by one. By running them in the test suite, the first > test, whatever it was, led to the second test failing. > > It seems that the way of stopping the server in the context of the test > is not effective. It's as if it prevents the second test from starting > the server. > > There may be a more appropriate way of stopping the new Zookeeper, but > with the time I had available, I thought it would be just as well to > start/stop the server once for all the tests. So I suggested modifying > the ZooKeeperBase class in that way. > > And now all the core-framework tests are OK ! > > > In a second step, I have included Mingchun Zhao's patch to migrate to > Java 11. > > I have created a Pull Request : > https://github.com/apache/manifoldcf/pull/150. > > > Bien regards, > Guylaine > > France Labs – Your knowledge, now > Datafari Enterprise Search – Découvrez la version 5 / Discover our version > 5 > www.datafari.com <http://www.datafari.com> > > > Le 05/09/2023 à 14:16, Karl Wright a écrit : > > I don't have any special influence in the Zookeeper project I fear. > > > > On Tue, Sep 5, 2023 at 3:46 AM Guylaine BASSETTE < > > guylaine.basse...@francelabs.com> wrote: > > > >> Hello Karl, > >> > >> Since we sent the ticket to Zookeeper, we've had no response from them. > >> Can we ask you for a little help to move the subject forward? > >> > >> Best regards, > >> Guylaine > >> > >> France Labs – Your knowledge, now > >> Datafari Enterprise Search – Découvrez la version 5 / Discover our > version > >> 5 > >> www.datafari.com <http://www.datafari.com> > >> Le 18/07/2023 à 17:19, Guylaine BASSETTE a écrit : > >>> Hello Karl, > >>> > >>> Thanks for your answer. > >>> > >>> We have created a Jira Bug to ZooKeeper: > >>> https://issues.apache.org/jira/browse/ZOOKEEPER-4722. > >>> > >>> They might contact you for help. > >>> > >>> > >>> Best regards, > >>> Guylaine > >>> > >>> France Labs – Your knowledge, now > >>> Datafari Enterprise Search – Découvrez la version 5 / Discover our > >>> version 5 > >>> www.datafari.com <http://www.datafari.com> > >>> > >>> > >>> Le 02/06/2023 à 01:04, Karl Wright a écrit : > >>>> Okay, it's as I suspected, the Zookeeper update didn't change any > >>>> functionality but just broke stuff. > >>>> > >>>> The first thing I'd do is alert the Solr team to the problem. They > >> should > >>>> for now roll back their dependency so that an earlier Zookeeper is > used. > >>>> The next step would be to work with the Zookeeper team to use > ManifoldCF > >>>> unit tests to allow them to fix the problem, as you say. Rather than > >>>> assuming this is the same problem we see in previous Zookeeper tickets > >> (it > >>>> probably is but we can't be sure of that), I'd create a new one > >> describing > >>>> very carefully how to reproduce this using a ManifoldCF branch > checkout. > >>>> Be prepared to interact with the Zookeeper team at some length about > the > >>>> problem and how to reproduce it. > >>>> > >>>> My sense is that Zookeeper's original authors are long gone and you > may > >> not > >>>> get very far here. And I have very limited time availability these > >> days. > >>>> If you are blocked in this in some way let me know and I will do my > >> best to > >>>> jump in and unblock you. > >>>> > >>>> I'd also fix the Solr 9 branch (after you make a copy of it for the > >>>> Zookeeper folks) so that a working version of Zookeeper is downloaded > >> and > >>>> we can then merge that branch. Please let me know when that is done > and > >>>> I'll integrate that work. > >>>> > >>>> Thanks, > >>>> Karl > >>>> > >>>> > >>>> On Thu, Jun 1, 2023 at 5:56 AM Guylaine BASSETTE < > >>>> guylaine.basse...@francelabs.com> wrote: > >>>> > >>>>> Hi Karl, > >>>>> > >>>>> Following up on your discussion with Julien. I did some further > >> testings > >>>>> and I’m commenting here because I cannot comment in the existing > ticket > >>>>> ( > >>>>> > >> > https://issues.apache.org/jira/browse/CONNECTORS-1740?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17643980#comment-17643980 > >>>>> < > >>>>> > >> > https://issues.apache.org/jira/browse/CONNECTORS-1740?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17643980#comment-17643980 > >>> ) > >>>>> . We tested the Solr 9 output connector using the ZK library in its > >>>>> 3.5.6 version, targeting a Solr 9.2, and it worked so for now this > >>>>> output connector can be considered as valid. > >>>>> > >>>>> Still, in the long run, I think this ZK bug will become an issue for > >>>>> MCF. Since thanks to your testings, the problem can be reproduced, > >>>>> wouldn’t it be worth for you to comment on their ZK issue, letting > them > >>>>> know that the issue is still here with ZK 3.5.7, that is does not > only > >>>>> happen in docker mode, and it can be reproduced every time using MCF > >>>>> testing framework ? > >>>>> > >>>>> -- > >>>>> > >>>>> Best Regards, > >>>>> Guylaine > >>>>> > >>>>> France Labs – Your knowledge, now > >>>>> Datafari Enterprise Search – Découvrez la version 5 / Discover our > >> version > >>>>> 5 > >>>>> www.datafari.com <http://www.datafari.com> > >>>>> > >>>>>
