One thing that I noticed is that: If we go into the code and check the files. They are still "executor". ex: EngineExecutorApp.scala If we are going to change "executor" to "server", we might need to modify the packages and most files.
I think it will be simpler for us to revert PR#21 first. Only make changes to include docker R support. (without changing name) Make another PR about name changing and we can discuss there. Best Regards Wei On Thu, May 23, 2019 at 1:21 PM Lucas Bonatto Miguel <lucasb...@apache.org> wrote: > Hey guys, in my last MR ( > https://github.com/apache/incubator-marvin/pull/21) > I added support for building docker images and also started implementing > what we discussed as being the new architecture, that will have its roots > on containers and REPL. > > During the work I realized that in the new context the engine-executor > would look more like an engine-server, given it's, in fact, a server for > marvin engines implemented in any language. > > I think I underestimated the impact of this change, and now I realized I > will need to send some updates on the documentation. Other than that, does > anyone see any other thing that needs to be done? > > Best, > Lucas >
