ArtifactType considers ejb a type (which is what dep.type will be), but also
knows the filename extension is ".jar".

IMO it makes sense to keep this logic together.

- Brett

> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] 
> Sent: Tuesday, 12 August 2003 2:58 PM
> To: Maven Developers List
> Subject: RE: cvs commit: 
> maven/src/java/org/apache/maven/project Project.j ava
> 
> 
> What's the difference between dependency.type and ArtifactType?
> --
> dIon Gillard, Multitask Consulting
> Blog:      http://blogs.codehaus.org/people/dion/
> 
> 
> Brett Porter <[EMAIL PROTECTED]> wrote on 11/08/2003 
> 04:32:38 PM:
> 
> > Should this be working with Artifacts? That way, this 
> method could be 
> > in ArtifactType.
> > 
> > >        /**
> > >   -     * Currently this is just jars.
> > >   +     * Jars and ejbs.
> > >         * 
> > >         * @param d
> > >         * @return true if the given dependency belongs on the
> > > classpath
> > >         */
> > >        private boolean isClasspathDependency(Dependency d)
> > >        {
> > >   -        return d.getType().equals( "jar" );
> > >   +        return d.getType().equals( "jar" ) || 
> > > d.getType().equals( "ejb" );
> > >        }
> > 
> > Cheers,
> > Brett
> 

Reply via email to