ok got it. I just pushed a fix for that. (the shared-http lib need to be shaded as well) I will start a second vote.
This vote is cancelled. On 12 September 2014 11:37, Dan Tran <dant...@gmail.com> wrote: > that works because M2_HOME/lib has jsoup.jar, common-io.jar, > commons-lang.jar ( those are NOT in 3.1.x) > > Try to remove commons-io.jar, it will fail since maven could not find a > commons-io class. The question here why maven could not find the same > class under wagon-http-2.7-shaded.jar > > -Dan > > > On Thu, Sep 11, 2014 at 5:49 PM, Olivier Lamy <ol...@apache.org> wrote: > >> So there is something here I don't understand or you have give me more >> details on how to test your problem. >> >> mb-olamy:http-download olamy$ mvn clean install -Dversion=1.0-beta-5 >> >> [INFO] Scanning for projects... >> >> [INFO] >> >> [INFO] >> ------------------------------------------------------------------------ >> >> [INFO] Building wagon-maven-plugin testing >> >> [INFO] >> ------------------------------------------------------------------------ >> >> Downloading: >> https://archiva-repository.apache.org/archiva/repository/all-public/org/codehaus/mojo/wagon-maven-plugin/1.0-beta-5/wagon-maven-plugin-1.0-beta-5.pom >> >> Downloaded: >> https://archiva-repository.apache.org/archiva/repository/all-public/org/codehaus/mojo/wagon-maven-plugin/1.0-beta-5/wagon-maven-plugin-1.0-beta-5.pom >> (6 KB at 2.2 KB/sec) >> >> Downloading: >> https://archiva-repository.apache.org/archiva/repository/all-public/org/codehaus/mojo/wagon-maven-plugin/1.0-beta-5/wagon-maven-plugin-1.0-beta-5.jar >> >> Downloaded: >> https://archiva-repository.apache.org/archiva/repository/all-public/org/codehaus/mojo/wagon-maven-plugin/1.0-beta-5/wagon-maven-plugin-1.0-beta-5.jar >> (50 KB at 21.7 KB/sec) >> >> [INFO] >> >> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ >> wagon-maven-plugin --- >> >> [INFO] >> >> [INFO] --- wagon-maven-plugin:1.0-beta-5:list (http-list) @ >> wagon-maven-plugin --- >> >> [INFO] Scanning remote file system: >> http://repo1.maven.org/maven2/commons-dbutils/commons-dbutils ... >> >> [INFO] maven-metadata.xml >> >> [INFO] maven-metadata.xml.md5 >> >> [INFO] maven-metadata.xml.sha1 >> >> [INFO] >> >> [INFO] --- wagon-maven-plugin:1.0-beta-5:download-single >> (http-download-single) @ wagon-maven-plugin --- >> >> [INFO] Downloading: >> >> http://repo1.maven.org/maven2/commons-dbutils/commons-dbutils/1.1/commons-dbutils-1.1-sources.jar >> to >> /Users/olamy/dev/sources/open-sources/mojo/mojo-trunk/wagon-maven-plugin/src/it/http-download/target/it/http-download/commons-dbutils-1.1-sources.jar >> >> [INFO] >> >> AFICS no issue. >> Note: I build a core version with wagon 2.7 artifacts. >> So please explain how to reproduce your problem. >> >> >> On 12 September 2014 07:31, Dan Tran <dant...@gmail.com> wrote: >> > check out >> > >> https://svn.codehaus.org/mojo/trunk/mojo/wagon-maven-plugin/src/it/http-download/ >> > >> > run >> > >> > mvn clean install -Dversion=1.0-beta-5 >> > >> > -D >> > >> > On Thu, Sep 11, 2014 at 2:24 PM, Olivier Lamy <ol...@apache.org> wrote: >> > >> >> How did you test that? >> >> >> >> -- >> >> Olivier >> >> On Sep 12, 2014 7:13 AM, "Dan Tran" <dant...@gmail.com> wrote: >> >> >> >> > Further test shows that http://jira.codehaus.org/browse/WAGON-407 is >> >> NOT >> >> > fixed so it is best to revert it, and mark as wont fix >> >> > >> >> > How it is tested >> >> > >> >> > under apache-maven-3.2.3/lib >> >> > >> >> > 1. Replace wagon*2.6* with wagon 2.7, I can use wagon-maven-plugin >> to >> >> > download. This worls >> >> > 2. Remove commons-io*.jar, the test fail, which means commons-io >> >> does >> >> > not get pickup by wagon-http-2.7-shared.jar doen work ( even thou I >> do >> >> see >> >> > commons-io got shaded) >> >> > >> >> > Thanks >> >> > >> >> > -D >> >> > >> >> > >> >> > >> >> > >> >> > On Thu, Sep 11, 2014 at 1:42 PM, Dan Tran <dant...@gmail.com> wrote: >> >> > >> >> > > tested by replace wagon*2.6 for wagon*2.6 under my maven-3.2.3/lib. >> >> > > >> >> > > It turns out maven 3.2.x now include jsoup, commons-io, and >> >> commons-lang >> >> > > under lib dir, so http://jira.codehaus.org/browse/WAGON-407 no >> longer >> >> > > needed unless maven dev remove thosed shaded file when ever wagon >> 2.7 >> >> got >> >> > > pushed into new maven release >> >> > > >> >> > > -Dan >> >> > > >> >> > > On Wed, Sep 10, 2014 at 10:29 PM, Olivier Lamy <ol...@apache.org> >> >> wrote: >> >> > > >> >> > >> Hi, >> >> > >> I'd like to release Apache Wagon 2.7 >> >> > >> We fixed 4 issues: >> >> > >> >> >> > >> >> >> > >> >> >> http://jira.codehaus.org/secure/ReleaseNote.jspa?version=20560&styleName=Text&projectId=10335&Create=Create >> >> > >> >> >> > >> Staging repository: >> >> > >> https://repository.apache.org/content/repositories/maven-1054/ >> >> > >> >> >> > >> Staging site: http://maven.apache.org/wagon-archives/wagon-LATEST/ >> >> > >> >> >> > >> Vote open for 72H >> >> > >> [+1] >> >> > >> [0] >> >> > >> [-1] >> >> > >> >> >> > >> Cheers >> >> > >> -- >> >> > >> Olivier Lamy >> >> > >> http://twitter.com/olamy | http://linkedin.com/in/olamy >> >> > >> >> >> > >> >> --------------------------------------------------------------------- >> >> > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> >> > >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> > >> >> >> > >> >> >> > > >> >> > >> >> >> >> >> >> -- >> Olivier Lamy >> http://twitter.com/olamy | http://linkedin.com/in/olamy >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
