That's the way this used to be; but they actually .solved. this
problem with the .gitattributes approach, so all we need to do is add
xml and properties files.

We just need to find out which of these should be added (from maven plugins):

Kristians-MacBook-Pro:maven-plugins kristian$ find . -type f | perl
-ne 'print $1 if m/\.([^.\/]+)$/' | sort -u

0-alpha-1-release-branch

1

1-with-installer-support

13f79535-47bb-0310-9956-ffa450edef68

2-beta-4

3

4

5

6

7

8

DSA

MF

PNG

Processor

RSA

SF

TXT

Test

aar

aj

apt

asc

bak

bsh

cache

cgi

checkstyle

checkstyle2

checkstyle_content

checkstyle_file

checkstyle_url

classpath

component

css

cvsignore

dtd

ext

file

filter

fml

g

gif

gitattributes

gitignore

gpg

groovy

gz

handlers

har

htaccess

html

idx

img

iml

j2ee

jar

java

jpg

js

jsp

launch

location

log

mar

md

md5

mdo

metadata

modulemaps

myhibernatedata

mymetadata

name

pack

par

patch

png

pom

prefs

project

properties

psd

rdf

repositories

sample

sar

schemas

sh

sha1

springBeans

txt

vm

war

websettings

website-config

wtpmodules

x

xar

xml

yml

zip

2014-10-12 15:52 GMT+02:00 Igor Fedorenko <i...@ifedorenko.com>:
> I am no git expert, but I believe proper text-vs-binary classification
> is only part of the solution. Git still needs to know what format to use
> in the repository and what format to use for the checkout. At least this
> was the case when I started using git, maybe modern versions are smarter
> about this.
>
> --
> Regards,
> Igor
>
>
> On 2014-10-12, 9:43, Kristian Rosenvold wrote:
>>
>> Ah ! The answer is that we don't leave it to the user to handle line
>> endings.
>>
>> I have added .gitattributes files to all our git repos, which
>> basically dictate how line endings should be handled.
>>
>> The thing is; it does not contain "xml" files. This is the one I have
>> added:
>>
>> *.java   text diff=java
>> *.html   text diff=html
>> *.css    text
>> *.js     text
>> *.sql    text
>>
>> So we need to add *.xml to all of them, and probably *.properties too.
>> Any others ?
>>
>> Kristian
>>
>>
>> 2014-10-12 14:53 GMT+02:00 Igor Fedorenko <i...@ifedorenko.com>:
>>>
>>> What EOL handling are we expected to use for Maven git repositories? I
>>> don't recall this was discussed before, but this commit [1] stands out
>>> from the rest. I usually follow github recommendation [2], so I wonder
>>> if we can adopt the same for Maven work. Any thoughts?
>>>
>>>
>>> [1]
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commitdiff;h=8506c638c6a21a902e85831185e2121d8ddcb55b
>>> [2] https://help.github.com/articles/dealing-with-line-endings/
>>>
>>> --
>>> Regards,
>>> Igor
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>> For additional commands, e-mail: dev-h...@maven.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to