Hi Norbert, Oh, I misses that one as well - our animal sniffer seems to put its nose only into the main classes.
A new pull-request would be great. Am Dienstag, 20. Januar 2015 schrieb Norbert Wnuk : > Hi Andreas, > The JDK API level is not enforced during build so that my accidental usage > of JDK 1.7 API in tests was not discovered till recent Jenkins build: > https://builds.apache.org/job/maven-surefire/1385/ Should I create new > pull > request / what is the procedure after closing original pull request? > > Regards, > NW > > On Tue, Jan 20, 2015 at 1:24 AM, Norbert Wnuk <norbertw...@gmail.com > <javascript:;>> wrote: > > > JIRA created, pull request with more mature fix attached (including > > integration test). > > > > https://jira.codehaus.org/browse/SUREFIRE-1136 > > https://github.com/apache/maven-surefire/pull/80 > > > > Regards, > > NW > > > > On Mon, Jan 19, 2015 at 8:03 AM, Karl Heinz Marbaise <khmarba...@gmx.de > <javascript:;>> > > wrote: > > > >> Hi Norbert, > >> > >> It's great that you asking for permission to create a jira but you don't > >> need to just create one and describe the situation etc. why and how it > went > >> wrong or what can be improved and of course your patch is really > >> great...but it would be much easier if you could either provide a test > for > >> your patch or at least add an example project which shows the wrong > >> behaviour... > >> > >> Thanks in advance > >> > >> Kind regards > >> Karl Heinz Marbaise > >> > >> > >> On 1/18/15 10:56 PM, Norbert Wnuk wrote: > >> > >>> Hi All, > >>> Not sure whether this is a proper place however Surefire webpage > >>> redirects to this mailing group. > >>> Recently we found two issues in Surefire plugin related to > >>> surefire.forkNumber variable and ability to define separate working > >>> directory per forked JVM. First issue is that the same directory is set > >>> for each of forked JVMs, the second problem is that surefire.forkNumber > >>> is expanded only for user.dir property and not for actual working > >>> directory (it leads to the situations like described here: > >>> http://stackoverflow.com/questions/1234795/why-is-the- > >>> user-dir-system-property-working-in-java). > >>> Attaching patch that resolves both problems for us (without test cases > >>> yet). Asking for a permission to create a JIRA. > >>> > >>> <workingDirectory>directory_${surefire.forkNumber}</workingDirectory> > >>> > >>> Regards, > >>> Norbert > >>> > >>> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org <javascript:;> > >> For additional commands, e-mail: dev-h...@maven.apache.org > <javascript:;> > >> > >> > > >
