My bad, it is not obvious it is from an experimental branch. However, even if this gets committed master, the configuration changes in that script may impact other distribution using M2_HOME.
Sorry, I am a little side track here. -D On Tue, Jan 27, 2015 at 2:07 PM, Igor Fedorenko <i...@ifedorenko.com> wrote: > You sure you linked the right commit? The commit you linked is from my > experimental branch and it does not change how mvn* scripts use M2_HOME > environment variable. > > -- > Regards, > Igor > > > On 2015-01-27 16:26, Dan Tran wrote: > >> Just see this change [1] at Maven core where the 'mvn' script get altered. >> >> Not sure about the impact of this change when using M2_HOME to support >> multiple is distributions. >> >> -Dan >> >> >> >> [1] >> https://git1-us-west.apache.org/repos/asf?p=maven.git;a= >> commitdiff;h=0a76e91b >> >> On Tue, Jan 27, 2015 at 11:38 AM, Dan Tran <dant...@gmail.com> wrote: >> >> Strange I don't have a problem with maven-release build running with >>> -Prun-its >>> >>> -D >>> >>> On Tue, Jan 27, 2015 at 11:20 AM, Benson Margulies < >>> bimargul...@gmail.com> >>> wrote: >>> >>> On Tue, Jan 27, 2015 at 2:10 PM, Dan Tran <dant...@gmail.com> wrote: >>>> >>>>> Hi Benson >>>>> >>>>> By "many tests" are you refer to the incident at release plugin 2.5.1, >>>>> >>>> or >>>> >>>>> maven-core IT >>>>> >>>> >>>> I'm guessing that the M-R-P integration tests are not the only plugin >>>> integration tests that care. I'm pretty sure I've run into this >>>> before. >>>> >>>> >>>> >>>>> Thanks >>>>> >>>>> -D >>>>> >>>>> On Tue, Jan 27, 2015 at 10:28 AM, Benson Margulies < >>>>> >>>> bimargul...@gmail.com> >>>> >>>>> wrote: >>>>> >>>>> On Tue, Jan 27, 2015 at 1:16 PM, Dan Tran <dant...@gmail.com> wrote: >>>>>> >>>>>>> Hi Benson, >>>>>>> >>>>>>> What is your verdict? >>>>>>> >>>>>> >>>>>> I vote for removing it from the publically facing doc. is there also a >>>>>> thought of removing it from the code? I guess if someone makes sure >>>>>> that all our many tests pass without it, fine with me. >>>>>> >>>>>> I should explain my passing reference to Aether. >>>>>> >>>>>> I wrote a little OSGi utility that uses Aether to fetch some >>>>>> dependencies, and I wanted it to get mirror definitions out of, well, >>>>>> $M2_HOME/conf/settings.xml. That probably counts as acute sloth on my >>>>>> part. >>>>>> >>>>>> >>>>>> >>>>>>> Thanks >>>>>>> >>>>>>> -D >>>>>>> >>>>>>> On Tue, Jan 27, 2015 at 3:15 AM, Benson Margulies < >>>>>>> >>>>>> bimargul...@gmail.com >>>> >>>>> >>>>>>> wrote: >>>>>>> >>>>>>> I know of two cases where it comes up. >>>>>>>> >>>>>>>> 1: some of our own ITs. Those aren't a reason for comprehensive doc. >>>>>>>> >>>>>>>> 2: an application I wrote for Aether :-) >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Tue, Jan 27, 2015 at 4:04 AM, Baptiste Mathus <m...@batmat.net> >>>>>>>> >>>>>>> wrote: >>>> >>>>> -1 it's a problematic variable, removing it is a good idea IMO, >>>>>>>>> >>>>>>>> and >>>> >>>>> changing mvn version is indeed just a matter of updating your >>>>>>>>> >>>>>>>> path. >>>> >>>>> >>>>>>>>> I've been hit many a time by an updated PATH pointing to a >>>>>>>>> >>>>>>>> different >>>> >>>>> mvn >>>>>> >>>>>>> version than the one referenced by M2_HOME, which ends with >>>>>>>>> NoClassDefFoundError or something like that IIRC. >>>>>>>>> That's why I've personally been advising maven users I encounter >>>>>>>>> >>>>>>>> to >>>> >>>>> never >>>>>> >>>>>>> ever set that variable for years. >>>>>>>>> >>>>>>>>> Cheers >>>>>>>>> >>>>>>>>> 2015-01-27 7:19 GMT+01:00 Anders Hammar <and...@hammar.net>: >>>>>>>>> >>>>>>>>> I would still suggest to make sure its documented somewhere. I >>>>>>>>>>> >>>>>>>>>> find it >>>>>> >>>>>>> incredibly useful to just change M2_HOME to simply switch Maven >>>>>>>>>>> >>>>>>>>>> versions. >>>>>>>> >>>>>>>>> >>>>>>>>>>> >>>>>>>>>> +1, very useful but I guess it doesn't require the name M2_HOME. >>>>>>>>>> >>>>>>>>>> /Anders >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> manfred >>>>>>>>>>> >>>>>>>>>>> Mirko Friedenhagen wrote on 26.01.2015 21:40: >>>>>>>>>>> >>>>>>>>>>> Dan, go ahead, I have not set this variable for years. >>>>>>>>>>>> >>>>>>>>>>>> Regards >>>>>>>>>>>> Mirko >>>>>>>>>>>> -- >>>>>>>>>>>> Sent from my mobile >>>>>>>>>>>> On Jan 27, 2015 5:52 AM, "Dan Tran" <dant...@gmail.com> >>>>>>>>>>>> >>>>>>>>>>> wrote: >>>> >>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> Any objection to remove the need to setup M2_HOME env >>>>>>>>>>>>> >>>>>>>>>>>> variable >>>> >>>>> at >>>>>> >>>>>>> maven >>>>>>>>>> >>>>>>>>>>> download page? >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> >>>>>>>>>>>>> -Dan >>>>>>>>>>>>> >>>>>>>>>>>>> https://jira.codehaus.org/browse/MNGSITE-223 >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> ------------------------------------------------------------ >>>>>> --------- >>>>>> >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>>>>>>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Baptiste <Batmat> MATHUS - http://batmat.net >>>>>>>>>> Sauvez un arbre, >>>>>>>>>> Mangez un castor ! >>>>>>>>>> nbsp;! >>>>>>>>>> >>>>>>>>>> >>>>>>>> >>>>>>>> ------------------------------------------------------------ >>>> --------- >>>> >>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>>>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>>>>>> >>>>>>>> >>>>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>>>> >>>>>> >>>>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>> >>>> >>>> >>> >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
