- blue for mojo is not really readable on my machine (Linux on black 
background)
- yellow is the OSX way to display bold: on my Linux machine, bold is rendered 
as bold white
- bold is used not only to display execution id

I'm really not convinced this is an improvement...

we'll really need to share screenshots to make choices

Regards,

Hervé

Le jeudi 16 juin 2016 15:36:32 schu...@apache.org a écrit :
> Repository: maven
> Updated Branches:
>   refs/heads/master bcaad5668 -> 71e4ff8e3
> 
> 
> [MNG-3507] added color to Maven execution output messages
> 
> o Updated to stop using colors green, yellow or red for anything not status
> related.
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/71e4ff8e
> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/71e4ff8e
> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/71e4ff8e
> 
> Branch: refs/heads/master
> Commit: 71e4ff8e358dd43fb52f2e760b82ef7ab39f1dbb
> Parents: bcaad56
> Author: Christian Schulte <schu...@apache.org>
> Authored: Thu Jun 16 17:34:31 2016 +0200
> Committer: Christian Schulte <schu...@apache.org>
> Committed: Thu Jun 16 17:34:31 2016 +0200
> 
> ----------------------------------------------------------------------
>  .../org/apache/maven/lifecycle/LifecycleExecutionException.java  | 2 +-
>  .../java/org/apache/maven/cli/event/ExecutionEventLogger.java    | 4 ++--
>  .../org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java  | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/maven/blob/71e4ff8e/maven-core/src/ma
> in/java/org/apache/maven/lifecycle/LifecycleExecutionException.java
> ---------------------------------------------------------------------- diff
> --git
> a/maven-core/src/main/java/org/apache/maven/lifecycle/LifecycleExecutionExc
> eption.java
> b/maven-core/src/main/java/org/apache/maven/lifecycle/LifecycleExecutionExc
> eption.java index fd4bca0..b94a7bc 100644
> ---
> a/maven-core/src/main/java/org/apache/maven/lifecycle/LifecycleExecutionExc
> eption.java +++
> b/maven-core/src/main/java/org/apache/maven/lifecycle/LifecycleExecutionExc
> eption.java @@ -84,7 +84,7 @@ public class LifecycleExecutionException
> 
>          if ( execution != null )
>          {
> -            buffer.a( ' ' ).a( execution.getGroupId() ).a( ':'
> ).fgGreen().a( execution.getArtifactId() ); +            buffer.a( ' ' ).a(
> execution.getGroupId() ).a( ':' ).a( execution.getArtifactId() ); buffer.a(
> ':' ).a( execution.getVersion() ).a( ':' ).a( execution.getGoal()
> ).reset(); buffer.bold().a( " (" ).a( execution.getExecutionId() ).a( ')'
> ).reset(); }
> 
> http://git-wip-us.apache.org/repos/asf/maven/blob/71e4ff8e/maven-embedder/sr
> c/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java
> ---------------------------------------------------------------------- diff
> --git
> a/maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLog
> ger.java
> b/maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLog
> ger.java index ee57121..7f5d65a 100644
> ---
> a/maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLog
> ger.java +++
> b/maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLog
> ger.java @@ -339,11 +339,11 @@ public class ExecutionEventLogger
> 
>      private void append( Ansi ansi, MojoExecution me )
>      {
> -        ansi.fgGreen().a( me.getArtifactId() ).a( ':' ).a( me.getVersion()
> ); +        ansi.fgBlue().a( me.getArtifactId() ).a( ':' ).a(
> me.getVersion() ); ansi.a( ':' ).a( me.getGoal() ).reset();
>          if ( me.getExecutionId() != null )
>          {
> -            ansi.bold().a( " (" ).a( me.getExecutionId() ).a( ')'
> ).reset(); +            ansi.fgBlue().bold().a( " (" ).a(
> me.getExecutionId() ).a( ')' ).reset(); }
>      }
> 
> 
> http://git-wip-us.apache.org/repos/asf/maven/blob/71e4ff8e/maven-embedder/sr
> c/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java
> ---------------------------------------------------------------------- diff
> --git
> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Col
> orRenderer.java
> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Col
> orRenderer.java index 52e0489..0f135dd 100644
> ---
> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Col
> orRenderer.java +++
> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Col
> orRenderer.java @@ -72,7 +72,7 @@ extends
> com.planet57.gossip.render.PatternRenderer {
>          StringBuilder tmp = new StringBuilder();
>          super.renderName( event, tmp, shortName );
> -        buff.append( ansi().fgGreen().a( tmp ).reset() );
> +        buff.append( ansi().fgBlue().a( tmp ).reset() );
>      }


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to