Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/118
One more job to do in *IT.java. Can you please add
`assumeThat(java.specification.version, is(greaterThan(1.7)));`.
A hint: Just lookup the text "java.specification.version" in ITs.
We use similar treatment for ITs using JDK7 and another ITs in
maven-failsafe-plugin as well.
I will call a vote for release soon and it is better really to not let PMC
see that build failed with JDK6.
The community starts the build by hands in the Vote and in my experience
they always had question and sometimes repeating still the same.
Do you have permissions to login to our Jenkins [1]?
Try to change the JDK without your commit yet and wait for the build. It
should not fail.
One the web page you will see Surefire job for Windows but not sure if JDK
8 can be there. Do not worry if this Win build is yellow because masine is
very slow (maybe GC) and use to fail the performance tests with JUnit7
parallel exec.
[1] https://builds.apache.org/job/maven-surefire/
If you want to refactor the test, try to do it before git push.
Yes I think it does not harm the project but please wait for the answer
from Jenkins.
Back to running the build on your laptop.
I do not know about your PC but mine spends 46 minutes for complete build
(mvn -Prun-its install).
It is Intel Core i7 3.00 GHz, 8 GHz using SSD. The hard drive really
matters, SSD better over spinning drives.
On Thu, Sep 8, 2016 at 10:59 AM, Benedikt Ritter <notificati...@github.com>
wrote:
> @tibor <https://github.com/tibor> this PR is only about introducing ITs.
> The M2 release of the provider is pulled in via maven as dependency, see
> the test pom.xml. I agree that surefire should not ship with a have
> finished JUnit 5 provider. But since this is just adding tests against an
> already released artifact, I don't see a reason not to merge it. We can
> extend the tests against milestone releases from the JUnit team and extend
> the test coverage. When we have a decent coverage we can move their
> provider implementation to surefire. The integration of the provider
should
> then be done in a separate branch.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/maven-surefire/pull/118#issuecomment-245536368>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AA_yR4X2xWe3kXTX66OVOW_ZFWUu4b1Oks5qn85ngaJpZM4J2QAo>
> .
>
--
Cheers
Tibor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
