Thank you for the analysis of the IT failures, Christian. I have a few questions/observations, if you don't mind
MavenITmng2199ParentVersionRangeTest.testValidLocalParentVersionRange >From what I can tell, module uses parent version=[1.0,2) which matches locally available parent version=1.1. Can you explain why this test is expected to fail? MavenITmng4600DependencyOptionalFlagManagementTest/MNG-5227 This seems rather major dependency resolution change for 3.4 release, but I do not have strong opinion about the change otherwise. MavenITmng3719PomExecutionOrderingTest Shows that Maven used to allow the same plugin used in multiple <plugin> elements. I am actually surprised this worked in 3.3.9, but I think this will be a real problem for project that rely on this behaviour. For other MNG-6075 changes, again, this maybe little too big a change for 3.4, but I think it is okay if remote pom.xml still work. Can you confirm that Maven is still able to use "old" pom.xml file from remote repositories? MavenIT0051ReleaseProfileTest and MavenITmng5805PkgTypeMojoConfiguration fail for me under Linux when using java7, but work on OSX with java8. I did not investigate these further. MavenITmng5640LifecycleParticipantAfterSessionEnd.testBuildErrorRt worked for me under linux with java7 but failed on osx with java8. I did not investigate this further. I agree with the rest of your conclusion. -- Regards, Igor On Thu, Nov 17, 2016, at 09:16 PM, Christian Schulte wrote: > Am 11/17/16 um 21:43 schrieb Christian Schulte: > > Am 11/17/16 um 06:00 schrieb Igor Fedorenko: > >> FWIW, I ran maven integration tests (commit 73a2b7) against current > >> maven master and got this > >> > >>> Tests run: 771, Failures: 3, Errors: 21, Skipped: 0 > >> > >> Running the same test checkout with Maven 3.3.9 > >> > >>> Tests run: 771, Failures: 0, Errors: 0, Skipped: 0 > > mng5783PluginDependencyFiltering(SLF4j) > mng5742BuildExtensionClassloader(BuildExtensionClassloader) > mng5578SessionScope(Basic_buildExtension) > mng5578SessionScope(Basic_multithreaded) > mng5753CustomMojoExecutionConfigurator(CustomMojoExecutionConfigurator) > mng5530MojoExecutionScope(_copyfiles_multithreaded) > mng5530MojoExecutionScope(Extension) > mng5530MojoExecutionScope(_copyfiles) > mng5805PkgTypeMojoConfiguration(PkgTypeMojoConfiguration) > > These ITs needed updating due to the new default maven-plugin-plugin > version in the 3.4 core. They are building 'maven-plugin' packaging > projects and the updated maven-plugin-plugin needed them to be touched. > > <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=fe47f97e78537c74a98a23f5f70af3c02afe4d66> > > <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=946bba40683f278eb47bbeaaaf8c23c8a9ad249f> > > Shouldn't be an issue. In Maven 3.4 you get a new default > maven-plugin-plugin version uncovering issues like this. No need to > revert anything, IMHO. > > mng2199ParentVersionRange(InvalidParentVersionRange) > mng2199ParentVersionRange(ValidLocalParentVersionRange) > > These two ITs did not correctly detect parent version ranges are not > working and got fixed by this commit: > > <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commitdiff;h=a6aca2894ab5a2849190cb802052710204081bf5> > > They did not fail since 3.2.3 although they should have failed. Got > fixed in 3.4. Nothing to worry about. > > mng3843PomInheritance(itMNG3843) > Expected to fail due to MNG-2478. > > mng4600DependencyOptionalFlagManagement(itModel) > Expected to fail due to MNG-5227. See > <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commitdiff;h=6d31bdd72116dc6cc8bfe6182321076b4b371558> > > mng5640LifecycleParticipantAfterSessionEnd(BuildErrorRt) > This one has not been changed in any way. I expect it to fail on my > machine locally only? Does this one fail for you as well? > > 0051ReleaseProfile(it0051) > Expected to fail due to MNG-5940. See > <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commitdiff;h=e10c629bfcc3cdb6d24f386d7209d5402dad241b>. > > mng1021EqualAttachmentBuildNumber(itMNG1021) > mng1701DuplicatePlugin(it) > mng3719PomExecutionOrdering(itMNG3719) > mng4005UniqueDependencyKey(itManagedDependency) > mng4005UniqueDependencyKey(itDependency) > mng4005UniqueDependencyKey(itProfileDependency) > mng4005UniqueDependencyKey(itProfileManagedDependency) > Expected to fail due to MNG-6075. See > <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=e7de36c506e8b0b442ffebdcd894bbb3600dfb26>. > > mng3259DepsDroppedInMultiModuleBuild(itMNG3259) > Expected to fail. See > <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commitdiff;h=bb1c2923f75547dc115307da3a64b1bf1938223a>. > > mng5805PkgTypeMojoConfiguration(PkgTypeMojoConfiguration) > Expected to fail due to MNG-5958. See > <https://git-wip-us.apache.org/repos/asf?p=maven-integration-testing.git;a=commit;h=d0cab3ba34abb2732382ab8ef44f6a125e589970>. > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
