Hi Christian,
This test looks normal to me. When loading the properties, through load
https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-,
the backslash indicates the line terminator, so it needs to be escaped,
otherwise the method would (silently) ignore it (if it doesn't represent
a valid escape sequence). So having
edge.escape.hanging=\\
in the properties file means that you'll read "\" for the
"edge.escape.hanging" property on the Java side. So it's testing that a
lone escape character doesn't cause any issues during filtering.
Guillaume
Le 22/11/2016 à 01:21, Christian Schulte a écrit :
Hi,
I am currently working on
<https://issues.apache.org/jira/browse/MSHARED-599> and am running into
an issue. With the fix in place an existing test case will start
failing. Here is the issue:
Please take a look at the following line
edge.escape.hanging=\\
from
<http://svn.apache.org/viewvc/maven/shared/trunk/maven-filtering/src/test/units-files/edge-cases/expected-filtered.properties?view=markup>.
With the fix in place, I would need to change that to
edge.escape.hanging=\
because the input to the filter looks like:
edge.escape.hanging=\\
in
<http://svn.apache.org/viewvc/maven/shared/trunk/maven-filtering/src/test/units-files/edge-cases/filtered/filtered.properties?view=markup>
and that is an escaped escape string which would need to become '\'
after filtering. Can I just remove that test case? I expect it is
testing something isn't hanging from somewhere in the past? Well. Seems
it is testing that escaping the escape string does not make something
hang - but incorrectly.
Regards,
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel
antivirus Avast.
https://www.avast.com/antivirus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
