Am 11/22/16 um 20:40 schrieb Guillaume Boué: > Hi Christian, > > This test looks normal to me. When loading the properties, through load > https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-, > > the backslash indicates the line terminator, so it needs to be escaped, > otherwise the method would (silently) ignore it (if it doesn't represent > a valid escape sequence). So having > > edge.escape.hanging=\\ > > > in the properties file means that you'll read "\" for the > "edge.escape.hanging" property on the Java side. So it's testing that a > lone escape character doesn't cause any issues during filtering. >
I am not questioning the way the properties are loaded. I am questioning the filtering itself. If the input is '\\', that is an escaped escape string. So the output needs to be '\' after filtering. It isn't because the escape string cannot be escaped. That's the issue I am fixing. I cannot fix that without changing that test case. Looking at this, there are cases where escaping the escape string leads to different output than before I don't know how to handle. IN = '\\' OUT = '\\' That's the issue. This needs to look like IN = '\\' OUT = '\' if the escape string is the backslash. There is this test case testing that the escape string does not get escaped. That may be intentionally. I don't know. Regards, -- Christian --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
