Le 30/12/2016 à 17:21, Christian Schulte a écrit :
Am 12/30/16 um 11:00 schrieb Guillaume Boué:
Hi Christian,
I remember adding those 2 ITs after raising a concern on dev (see
attached mail). They were passing with 3.3.9 and latest 3.4.0 at that time.
Is there an issue updating those tests with regard to MNG-5457? I
noticed this is the 5th commit changing it (which I think is a lot), but
the build is still failing on Jenkins and locally with 3.3.9. Maybe we
can assert that the file was actually downloaded in a different manner,
like deleting the folder in the local repository in a setup script, and
testing that the POM and JAR files are present in the local repository
in the verify script? This is what I did in, e.g., the IT "get-artifact".
Another simple solution would be to assert that the log file contains
either "Downloading:" or "Downloading from ...", instead of using a
regular expression (I verified locally that this works fine).
Do you have a Windows box at hand? Would be cool if you could fix those
two scripts to work an Windows. I would have to wait another 2.5 hours
just to find out it's still not working.
I can build all plugins using current 3.4.0-SNAPSHOT by doing:
mvn -DmavenPluginToolsVersion=3.5 -Prun-its verify
There is this issue on Windows and there is another issue with the
maven-assembly-plugin which seems to be related to the invoker or the
updates to the Windows launcher scripts. If you could take a look at it
as well, would also be cool. Failing IT is here:
<https://builds.apache.org/view/Maven/job/maven-master-release-status-test-plugins-windows/ws/plugins-trunk/maven-assembly-plugin/target/it/projects/basic-features/space%20&%20special%20char/>
build.log contains:
'special' is not recognized as an internal or external command,
operable program or batch file.
The system cannot find the path specified.
The system cannot find the path specified.
Maybe an issue with the current mvn.cmd launcher. Someone with Windows
may fix this in a few minutes.
I remember looking into them. It's actually an issue with the launcher
script on Windows, that is fixed with 3.4.0. Perhaps we can mark the
build as expected to fail with < 3.4.0, and then have the passing one
with >= 3.4.0.
If you step over such an issue, I would not mind if you just fix it and
commit. That's what I am doing as well. Reading some code and noticing
someone just committed something not working for me, I just fix it and
commit it. There is no need to write tons of emails. I do read commit
messages. That's also a channel to use for communication.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel
antivirus Avast.
https://www.avast.com/antivirus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
