Yes but is this failing because of a regression in core or surefire?

On 18 February 2017 at 17:32, Tibor Digana <[email protected]> wrote:

> Hi Stephen,
>
> Both branches should be merged together.
> SUREFIRE_SYSPROP_DUPLICATES
> SUREFIRE_STDOUT_FLUSH
> All tests should pass then.
> Cheers
> Tibor
>
> On Sat, Feb 18, 2017 at 6:21 PM, Tibor Digana-2 [via Maven] <
> [email protected]> wrote:
>
> > We had this problem and the branch SUREFIRE_SYSPROP_DUPLICATES should fix
> > it.
> >
> > On Sat, Feb 18, 2017 at 6:12 PM, Stephen Connolly <
> > [hidden email] <http:///user/SendEmail.jtp?type=node&node=5899136&i=0>>
> > wrote:
> >
> > > So Maven 3.5.0-SNAPSHOT just has one failure:
> > >
> > >
> > > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 14.835
> > sec
> > > <<< FAILURE!
> > >
> > > shouldNotBeVerbose(org.apache.maven.surefire.its.
> CheckTestNgReportTestIT)
> >
> > > Time elapsed: 0 sec  <<< FAILURE!
> > >
> > > java.lang.AssertionError: log pattern does not match nTimes
> > >
> > > Expected: is <0>
> > >
> > >      but: was <1>
> > >
> > >         at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:
> 20)
> > >
> > >         at
> > > org.apache.maven.surefire.its.fixture.OutputValidator.
> assertThatLogLine(
> >
> > > OutputValidator.java:104)
> > >
> > >         at
> > > org.apache.maven.surefire.its.CheckTestNgReportTestIT.
> shouldNotBeVerbose(
> >
> > > CheckTestNgReportTestIT.java:55)
> > >
> > >         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > >
> > >         at
> > > sun.reflect.NativeMethodAccessorImpl.invoke(
> NativeMethodAccessorImpl.java:
> >
> > > 62)
> > >
> > >         at
> > > sun.reflect.DelegatingMethodAccessorImpl.invoke(
> > > DelegatingMethodAccessorImpl.java:43)
> > >
> > >         at java.lang.reflect.Method.invoke(Method.java:498)
> > >
> > >         at
> > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(
> > > FrameworkMethod.java:50)
> > >
> > >         at
> > > org.junit.internal.runners.model.ReflectiveCallable.run(
> > > ReflectiveCallable.java:12)
> > >
> > >         at
> > > org.junit.runners.model.FrameworkMethod.invokeExplosively(
> > > FrameworkMethod.java:47)
> > >
> > >         at
> > > org.junit.internal.runners.statements.InvokeMethod.
> > > evaluate(InvokeMethod.java:17)
> > >
> > >         at org.junit.runners.ParentRunner.runLeaf(
> ParentRunner.java:325)
> >
> > >
> > >         at
> > > org.junit.runners.BlockJUnit4ClassRunner.runChild(
> > > BlockJUnit4ClassRunner.java:78)
> > >
> > >         at
> > > org.junit.runners.BlockJUnit4ClassRunner.runChild(
> > > BlockJUnit4ClassRunner.java:57)
> > >
> > >         at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> > >
> > >         at org.junit.runners.ParentRunner$1.schedule(
> ParentRunner.java:71)
> >
> > >
> > >         at org.junit.runners.ParentRunner.runChildren(
> > > ParentRunner.java:288)
> > >
> > >         at org.junit.runners.ParentRunner.access$000(
> ParentRunner.java:58)
> >
> > >
> > >         at org.junit.runners.ParentRunner$2.evaluate(
> > > ParentRunner.java:268)
> > >
> > >         at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> > >
> > >         at org.junit.runners.Suite.runChild(Suite.java:128)
> > >
> > >         at org.junit.runners.Suite.runChild(Suite.java:27)
> > >
> > >         at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> > >
> > >         at org.junit.runners.ParentRunner$1.schedule(
> ParentRunner.java:71)
> >
> > >
> > >         at org.junit.runners.ParentRunner.runChildren(
> > > ParentRunner.java:288)
> > >
> > >         at org.junit.runners.ParentRunner.access$000(
> ParentRunner.java:58)
> >
> > >
> > >         at org.junit.runners.ParentRunner$2.evaluate(
> > > ParentRunner.java:268)
> > >
> > >         at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> > >
> > >         at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> > >
> > >         at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
> > >
> > >         at
> > > org.apache.maven.surefire.junitcore.JUnitCoreWrapper.
> > > execute(JUnitCoreWrapper.java:62)
> > >
> > >         at
> > > org.apache.maven.surefire.junitcore.JUnitCoreProvider.
> > > invoke(JUnitCoreProvider.java:139)
> > >
> > >         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > >
> > >         at
> > > sun.reflect.NativeMethodAccessorImpl.invoke(
> NativeMethodAccessorImpl.java:
> >
> > > 62)
> > >
> > >         at
> > > sun.reflect.DelegatingMethodAccessorImpl.invoke(
> > > DelegatingMethodAccessorImpl.java:43)
> > >
> > >         at java.lang.reflect.Method.invoke(Method.java:498)
> > >
> > >         at
> > > org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(
> > > ReflectionUtils.java:189)
> > >
> > >         at
> > > org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(
> > > ProviderFactory.java:165)
> > >
> > >         at
> > > org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(
> > > ProviderFactory.java:85)
> > >
> > >         at
> > > org.apache.maven.plugin.surefire.InPluginVMSurefireStarter.
> > > runSuitesInProcess(InPluginVMSurefireStarter.java:80)
> > >
> > >         at
> > > org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(
> > > AbstractSurefireMojo.java:724)
> > >
> > >         at
> > > org.apache.maven.plugin.surefire.AbstractSurefireMojo.
> executeAllProviders(
> >
> > > AbstractSurefireMojo.java:682)
> > >
> > >         at
> > > org.apache.maven.plugin.surefire.AbstractSurefireMojo.
> > > executeAfterPreconditionsChecked(AbstractSurefireMojo.java:648)
> > >
> > >         at
> > > org.apache.maven.plugin.surefire.AbstractSurefireMojo.
> > > execute(AbstractSurefireMojo.java:586)
> > >
> > >         at
> > > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(
> > > DefaultBuildPluginManager.java:134)
> > >
> > >         at
> > > org.apache.maven.lifecycle.internal.MojoExecutor.execute(
> > > MojoExecutor.java:207)
> > >
> > >         at
> > > org.apache.maven.lifecycle.internal.MojoExecutor.execute(
> > > MojoExecutor.java:153)
> > >
> > >         at
> > > org.apache.maven.lifecycle.internal.MojoExecutor.execute(
> > > MojoExecutor.java:145)
> > >
> > >         at
> > > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
> buildProject(
> >
> > > LifecycleModuleBuilder.java:116)
> > >
> > >         at
> > > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
> buildProject(
> >
> > > LifecycleModuleBuilder.java:80)
> > >
> > >         at
> > > org.apache.maven.lifecycle.internal.builder.singlethreaded.
> > > SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> > >
> > >         at
> > > org.apache.maven.lifecycle.internal.LifecycleStarter.
> > > execute(LifecycleStarter.java:128)
> > >
> > >         at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:
> 309)
> >
> > >
> > >         at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:
> 194)
> >
> > >
> > >         at org.apache.maven.DefaultMaven.
> execute(DefaultMaven.java:107)
> > >
> > >         at org.apache.maven.cli.MavenCli.execute(MavenCli.java:907)
> > >
> > >         at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:304)
> > >
> > >         at org.apache.maven.cli.MavenCli.main(MavenCli.java:208)
> > >
> > >         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > >
> > >         at
> > > sun.reflect.NativeMethodAccessorImpl.invoke(
> NativeMethodAccessorImpl.java:
> >
> > > 62)
> > >
> > >         at
> > > sun.reflect.DelegatingMethodAccessorImpl.invoke(
> > > DelegatingMethodAccessorImpl.java:43)
> > >
> > >         at java.lang.reflect.Method.invoke(Method.java:498)
> > >
> > >         at
> > > org.codehaus.plexus.classworlds.launcher.Launcher.
> > > launchEnhanced(Launcher.java:289)
> > >
> > >         at
> > > org.codehaus.plexus.classworlds.launcher.Launcher.
> > > launch(Launcher.java:229)
> > >
> > >         at
> > > org.codehaus.plexus.classworlds.launcher.Launcher.
> > > mainWithExitCode(Launcher.java:415)
> > >
> > >         at
> > > org.codehaus.plexus.classworlds.launcher.Launcher.
> main(Launcher.java:356)
> >
> > >
> > >
> > > Running org.apache.maven.surefire.its.jiras.
> Surefire995CategoryInheritance
> >
> > > IT
> > >
> > > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.469
> > sec
> > >
> > > Running org.apache.maven.surefire.its.TestMultipleMethodPatternsTest
> NGIT
> >
> > >
> > > Tests run: 90, Failures: 0, Errors: 0, Skipped: 41, Time elapsed:
> > 190.874
> > > sec
> > >
> > > Running org.apache.maven.surefire.its.TestMultipleMethodPatternsIT
> > >
> > > Tests run: 180, Failures: 0, Errors: 0, Skipped: 87, Time elapsed:
> > 359.579
> > > sec
> > >
> > >
> > > Results :
> > >
> > >
> > > Failed tests:
> > > shouldNotBeVerbose(org.apache.maven.surefire.its.
> CheckTestNgReportTestIT):
> >
> > > log pattern does not match nTimes(..)
> > >
> > >
> > > Tests run: 714, Failures: 1, Errors: 0, Skipped: 133
> > >
> > >
> > >
> > > On 18 February 2017 at 16:19, Tibor Digana <[hidden email]
> > <http:///user/SendEmail.jtp?type=node&node=5899136&i=1>>
> > > wrote:
> > >
> > > > I have downloaded Michaels log for Maven 3.3.9 & Surefire
> > 2.19.2-SNAPSHOT
> > > > http://home.apache.org/~michaelo/maven/surefire/maven-
> > > > surefire-extended-patch-maven-3.3.9.tar.gz
> > > > and 27 tests failed.
> > > >
> > > >
> > > > On Sat, Feb 18, 2017 at 4:52 PM, Stephen Connolly <
> > > > [hidden email] <http:///user/SendEmail.jtp?
> type=node&node=5899136&i=2>>
> > wrote:
> > > >
> > > > > So results so far: surefire master branch builds with 3.3.9 but
> > fails
> > > > with
> > > > > 3.5.0-SNAPSHOT when running on macOS Sierra with Oracle Java
> > 1.8.0_121
> > > > >
> > > > > That is certainly looking like a regression in Maven core
> > > > >
> > > > > On 18 February 2017 at 10:55, Michael Osipov <[hidden email]
> > <http:///user/SendEmail.jtp?type=node&node=5899136&i=3>>
> > > > wrote:
> > > > >
> > > > > > For those who would like to reproduce the issues:
> > > > > >
> > > > > > 1. Build Maven distribution from 3.3.9, master, MNG-6169 and
> > MNG-6169
> > > > > with
> > > > > > locally modified maven-core/src/main/resources/
> > > > > META-INF/plexus/components.xml
> > > > > > maven-clean-plugin 2.6.1 => 3.0.0.
> > > > > > You should have four distros now.
> > > > > > 2. Clone Surefire
> > > > > > 3. Run all four versions of Maven against Surefire master:
> > > > > > > ~/apache-maven-$version/bin/mvn -B -V clean install
> > > > > > -Dinvoker.mergeSettings | tee ~/maven-surefire.log
> > > > > > Leave mergeSettings out if you have direct Internet connection
> > > > > > 4. Save maven-surefire.log and surefire-integration-tests/target
> > for
> > > > > > later analysis
> > > > > > 5. Branch off Surefire master and apply branches:
> > > > > > origin/SUREFIRE_STDOUT_FLUSH
> > > > > > origin/SUREFIRE_SYSPROP_DUPLICATES
> > > > > > 6. Repeat step 3
> > > > > > 7. Checkout maven-shared-utils-0.9.x from Subversion, install and
> > > > update
> > > > > > maven-surefire/pom.xml with version 0.9.1-SNAPSHOT
> > > > > > 8. Repeat 6
> > > > > > 7. Compare results of 3, 5, 6, 8 as well as with my
> > > maven-surefire.log
> > > > > > files
> > > > > >
> > > > > > note: my logs are based on an already patched version (from
> > mentioned
> > > > > > branches) of Surefire master.
> > > > > >
> > > > > >
> > > > > > Michael
> > > > > >
> > > > > > ------------------------------------------------------------
> > > ---------
> > > > > > To unsubscribe, e-mail: [hidden email]
> > <http:///user/SendEmail.jtp?type=node&node=5899136&i=4>
> > > > > > For additional commands, e-mail: [hidden email]
> > <http:///user/SendEmail.jtp?type=node&node=5899136&i=5>
> > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Cheers
> > > > Tibor
> > > >
> > >
> >
> >
> >
> > --
> > Cheers
> > Tibor
> >
> >
> > ------------------------------
> > If you reply to this email, your message will be added to the discussion
> > below:
> > http://maven.40175.n5.nabble.com/Recent-issues-found-in-
> > Surefire-master-Maven-Clean-Plugin-3-0-0-with-Maven-
> > master-tp5898937p5899136.html
> > To start a new topic under Maven Developers, email
> > [email protected]
> > To unsubscribe from Maven Developers, click here
> > <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?
> macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3
> wxNDIxNjZ8LTI4OTQ5MjEwMg==>
> > .
> > NAML
> > <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?
> macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&
> base=nabble.naml.namespaces.BasicNamespace-nabble.view.
> web.template.NabbleNamespace-nabble.view.web.template.
> NodeNamespace&breadcrumbs=notify_subscribers%21nabble%
> 3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_
> instant_email%21nabble%3Aemail.naml>
> >
>
>
>
>
> --
> View this message in context: http://maven.40175.n5.nabble.
> com/Recent-issues-found-in-Surefire-master-Maven-Clean-
> Plugin-3-0-0-with-Maven-master-tp5898937p5899138.html
> Sent from the Maven Developers mailing list archive at Nabble.com.

Reply via email to