Ok perso I don't mind (it just need to be documented) But the issue is: users are used to simply upgrade their junit dependency.
On Wed, 5 Sep 2018 at 07:37, Christian Stein <[email protected]> wrote: > No, it works with Surefire 2.22.0 and JUnit 5.3. > > Just add (or move) the test-runtime dependencies to the Surefire plugin > element: > > <build> > <plugins> > <!-- JUnit 5 requires Surefire version 2.22.0 or higher --> > <plugin> > <artifactId>maven-surefire-plugin</artifactId> > <version>2.22.0</version> > <dependencies> > <dependency> > <groupId>org.junit.jupiter</groupId> > <artifactId>junit-jupiter-engine</artifactId> > <version>5.3.0</version> > </dependency> > </dependencies> > </plugin> > </plugins> > </build> > > > Just checking our sample builds over at JUnit 5. Which do _NOT_ do this at > the moment. > > > > On Tue, Sep 4, 2018 at 11:32 PM Olivier Lamy <[email protected]> wrote: > > > Hi > > very embarrassing issue which probably worth a quick release! > > Can you create a jira? > > As junit 5.3.0 has just been released, I might be happy to cut 2.22.1 > very > > quickly with only this fix. > > others wdyt? > > > > > > On Wed, 5 Sep 2018 at 06:46, Romain Manni-Bucau <[email protected]> > > wrote: > > > > > Hi guys, > > > > > > Jira seems down so sending a mail. > > > > > > I wanted to upgrade Meecrowave to JUnit 5.3 since it is out but I > > realized > > > the way surefire provider was developped for JUnit 5 was forcing the > > > junit-platform-engine even adding it manually in the test dependencies > or > > > plugin dependencies. > > > > > > Side note: I didn't investigated other providers but I guess it is the > > > exact same but the API breakage are happening less often. > > > > > > I therefore created a PR to fix that -> > > > https://github.com/apache/maven-surefire/pull/193 > > > > > > Note: I didn't upgrade the JUnit 5 version in the same release but it > > > should probably be done too in another commit/PR. > > > > > > I wonder if you have release plans which could include this. In terms > of > > > issues I have in mind the other thing about JUnit 5 which would be > great > > to > > > add is the support for display names instead of using the class+test > > names > > > in the logs and reports but this is less mandatory than previous one > > which > > > fails with a NoSuchMethod error when using vintage engine. > > > > > > Romain Manni-Bucau > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > > <https://rmannibucau.metawerx.net/> | Old Blog > > > <http://rmannibucau.wordpress.com> | Github < > > > https://github.com/rmannibucau> | > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > > < > > > > > > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > > > > > > > > > -- > > Olivier Lamy > > http://twitter.com/olamy | http://linkedin.com/in/olamy > > > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
