>From what I saw in the code the surefire provider artifact is resolved to build the classpath ignoring the project configuration (it is just an artifact resolution) and therefore it ignores the project overrides without my patch.
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le mer. 5 sept. 2018 à 10:14, Stephane Nicoll <[email protected]> a écrit : > I am more interested to understand what is particular in that project that > exhibits an issue we don't seem to be facing. That thread is phrased in > such a way that it is a general problem and I'd like a confirmation of that > as it may impact Spring Boot (amongst other things) > > Thanks, > S. > > > On Wed, Sep 5, 2018 at 10:13 AM Romain Manni-Bucau <[email protected]> > wrote: > > > @Stephane: you can clone https://github.com/apache/meecrowave/tree/trunk > > and change the version in the junit pom ( > > https://github.com/apache/meecrowave/blob/trunk/meecrowave-junit/pom.xml > ), > > it will fail then > > > > Romain Manni-Bucau > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > <https://rmannibucau.metawerx.net/> | Old Blog > > <http://rmannibucau.wordpress.com> | Github < > > https://github.com/rmannibucau> | > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > < > > > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > > > > > Le mer. 5 sept. 2018 à 10:07, Stephane Nicoll <[email protected] > > > > a > > écrit : > > > > > How do I reproduce this problem concretely? Having to specify a > > dependency > > > in surefire is not an option for us as we want the JUnit5 provider to > be > > > detected automatically. > > > > > > I've upgraded a Spring Boot project to use 5.3.0 and I don't see any > > > problem. > > > > > > Thanks, > > > S. > > > > > > > > > On Tue, Sep 4, 2018 at 10:46 PM Romain Manni-Bucau < > > [email protected]> > > > wrote: > > > > > > > Hi guys, > > > > > > > > Jira seems down so sending a mail. > > > > > > > > I wanted to upgrade Meecrowave to JUnit 5.3 since it is out but I > > > realized > > > > the way surefire provider was developped for JUnit 5 was forcing the > > > > junit-platform-engine even adding it manually in the test > dependencies > > or > > > > plugin dependencies. > > > > > > > > Side note: I didn't investigated other providers but I guess it is > the > > > > exact same but the API breakage are happening less often. > > > > > > > > I therefore created a PR to fix that -> > > > > https://github.com/apache/maven-surefire/pull/193 > > > > > > > > Note: I didn't upgrade the JUnit 5 version in the same release but it > > > > should probably be done too in another commit/PR. > > > > > > > > I wonder if you have release plans which could include this. In terms > > of > > > > issues I have in mind the other thing about JUnit 5 which would be > > great > > > to > > > > add is the support for display names instead of using the class+test > > > names > > > > in the logs and reports but this is less mandatory than previous one > > > which > > > > fails with a NoSuchMethod error when using vintage engine. > > > > > > > > Romain Manni-Bucau > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > > > <https://rmannibucau.metawerx.net/> | Old Blog > > > > <http://rmannibucau.wordpress.com> | Github < > > > > https://github.com/rmannibucau> | > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > > > < > > > > > > > > > > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > > > > > > > > > > >
