Hi,
the adjusted @Named annotation is on DefaultModelProcessor, not
DefaultModelBuilder.
They both implement the ModelBuilder interface, but the one that
extensions like to overwrite is the implementation of DefaultModelBuilder.
So I'd prefer to stick to "core" as proposed my Stuart.
thanks for the confirmation that this works,
Robert
On Fri, 18 Oct 2019 21:10:18 +0200, Jason van Zyl <jvan...@apache.org>
wrote:
Hi,
As noted in Slack I think it would be more clear if we used something
like
@Named( “allowDefaultOverride” )
vs
@Named( “core” )
As that expresses the intent and can be used anywhere it's allowed for a
client to override the default component.
The tests in polyglot all pass with this change, and I’m able to run
polyglot example projects again, so I assume the Tycho POM-less are
happy again as well but hopefully someone can verify.
Jason
On Oct 18, 2019, at 2:04 PM, Robert Scholte <rfscho...@apache.org>
wrote:
Hi,
with the help from Stuart McCulloch we've been able to provide a patch
for MNG-6765[1]
Please review and test.
thanks,
Robert
[1] https://issues.apache.org/jira/browse/MNG-67
[2]
https://github.com/apache/maven/commit/24e6c0ec0a87b6682513287a23c36db6996b874c
[3]
https://github.com/apache/maven/commit/53a70bc8543124569ee787725b2004bc92a681b6
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
