Any string apart from "default" or the empty string will work here - I happened to chose "core" because I viewed it as a core implementation.
Also a quick reminder that this is only needed when a component uses @Typed and wants to allow overriding, it's not necessary in any other situation - so in that sense "allowDefaultOverride" wouldn't be quite accurate. (See the javadoc in the patch for more detail.) PS. the reason DefaultModelProcessor needs to use @Typed is because it has an "interesting" interface hierarchy where ModelProcessor extends both ModelLocator and ModelReader, so it can act as both and delegate accordingly - but then it also asks to have a ModelLocator and ModelReader injected, which is where things get messy. If it had a cleaner hierarchy (ie. it wasn't asking to inject something that it also implements) then it wouldn't need @Typed and wouldn't then need the custom name. On Fri, 18 Oct 2019 at 20:35, Robert Scholte <[email protected]> wrote: > Hi, > > the adjusted @Named annotation is on DefaultModelProcessor, not > DefaultModelBuilder. > They both implement the ModelBuilder interface, but the one that > extensions like to overwrite is the implementation of DefaultModelBuilder. > So I'd prefer to stick to "core" as proposed my Stuart. > > thanks for the confirmation that this works, > Robert > > On Fri, 18 Oct 2019 21:10:18 +0200, Jason van Zyl <[email protected]> > wrote: > > > Hi, > > > > As noted in Slack I think it would be more clear if we used something > > like > > > > @Named( “allowDefaultOverride” ) > > > > vs > > > > @Named( “core” ) > > > > As that expresses the intent and can be used anywhere it's allowed for > a > > client to override the default component. > > > > The tests in polyglot all pass with this change, and I’m able to run > > polyglot example projects again, so I assume the Tycho POM-less are > > happy again as well but hopefully someone can verify. > > > > Jason > > > >> On Oct 18, 2019, at 2:04 PM, Robert Scholte <[email protected]> > >> wrote: > >> > >> Hi, > >> > >> with the help from Stuart McCulloch we've been able to provide a patch > >> for MNG-6765[1] > >> Please review and test. > >> > >> thanks, > >> Robert > >> > >> [1] https://issues.apache.org/jira/browse/MNG-67 > >> [2] > >> > https://github.com/apache/maven/commit/24e6c0ec0a87b6682513287a23c36db6996b874c > >> [3] > >> > https://github.com/apache/maven/commit/53a70bc8543124569ee787725b2004bc92a681b6 > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
