OK. With that in mind, I think the surefire plugin shouldn't require a newer version of JUnit in a maintenance release that way. I understand it's fixed and can lead to problem anyway but there will be less problems if you rely on an older version and backward compatiblity if a newer version is around. I think we need to weigh what that change brings vs. the impact on existing users upgrading to 2.22.3
On Mon, May 4, 2020 at 7:36 PM Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > Yes but with transitive game it is not well positionned in the classpath > (once again not saying it is "right", just the way it was done originally) > and surefire provider dependencies win so it must be redefined to be used > in 2.x. > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github < > https://github.com/rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > < > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > Le lun. 4 mai 2020 à 18:52, Christian Stein <sormu...@gmail.com> a écrit : > > > On Mon, May 4, 2020 at 6:45 PM Romain Manni-Bucau <rmannibu...@gmail.com > > > > wrote: > > > > > Le lun. 4 mai 2020 à 18:30, Stephane Nicoll <stephane.nic...@gmail.com > > > > a > > > écrit : > > > > > > ... > > > > > OK. Why is our build failing with that error if we're importing the > JUnit > > > > 5.5.2 bom and it does not fail if we're importing the JUnit 5.6.2 > bom? > > > Our > > > > test dependencies have "junit-jupiter" in test scope which brings the > > > > engine. > > > > > > > > That looks like Surefire is using the user version to me. Anyway, if > it > > > > wasn't we wouldn't have the error above, wouldn't we? > > > > > > > > > > AFAIK you don't import junit-platform-launcher in 1.5.2 so it fails. > > > So surefire uses user version but misses one dep which takes in its own > > > pom. > > > > > > > > > > > https://repo.maven.apache.org/maven2/org/junit/junit-bom/5.5.2/junit-bom-5.5.2.pom > > > > > > contains > > > > <dependency> > > <groupId>org.junit.platform</groupId> > > <artifactId>junit-platform-launcher</artifactId> > > <version>1.5.2</version> > > </dependency> > > >
