Hi Anders, those are outdated – not everything you need is included, at least for IntelliJ. YMMV when using those.
There is a lot which could be done. E.g. updating those files, some general code guidelines (like: do not use guard statements, rather use an else), etc., when (not) to use Optionals, when to use which Logger, when to keep compatibility to Java 7/8 for plugin x/y… It is not just about code style! But speaking about code style: I saw Christian (junit) using a fmt-maven-plugin [1]. That would be helpful, too, unless checkstyle can do the same now. [1]: https://github.com/sormuras/junit-platform-maven-plugin/blob/master/pom.xml#L294-L314 Am Di., 22. Dez. 2020 um 14:51 Uhr schrieb Anders Hammar <and...@hammar.net >: > There are settings files here: > http://maven.apache.org/developers/conventions/code.html > > /Anders > > On Tue, Dec 22, 2020 at 2:47 PM Gary Gregory <garydgreg...@gmail.com> > wrote: > > > It would be great if one could download Eclipse or Idea settings files, > or > > better yet, include them in each repo. > > > > Gary > > > > On Tue, Dec 22, 2020, 08:34 Sandra Parsick <spars...@web.de> wrote: > > > > > Hello dev-list, > > > > > > some weeks ago, I have started creating some Pull Requests for the > Maven > > > JLink Plugin [1]. There were many hints about coding rules or decision > > > which version / libs etc should be used and more. So I need some > > > iterations till a trivial (IMHO) PR was accepted or in one case to find > > > out the PR was completely unnecessary. That was a little bit > frustating. > > > I think it would be easier for new contributor to have a guideline or > > > checklist of things to consider. I would love to help create such a > > > checklist or guideline to lower the barrier to entry for contributing. > I > > > already discuss the idea with Ben and he has agreed to help. So what do > > > you think about this idea? If this idea finds approval, where is the > > > best place to place it? > > > > > > Best regards, > > > > > > Sandra > > > > > > [1] > > > > > > > > > https://github.com/apache/maven-jlink-plugin/pulls?q=is%3Apr+is%3Aclosed+author%3Asparsick > > > > > > > > >
