AFAIK the eclipse one is not outdated. I suggest to update these. I am aware of editor-config, but it has one huge problem: you cannot refer to a centralized file. This means that IF we would use them, we need to keep them in sync for all ~100 repositories, which is a big no for me. Updating the IDE specific files seems like the appropriate way to handle this.
thanks, Robert On 23-12-2020 12:39:11, Sandra Parsick <spars...@web.de> wrote: > those are outdated – not everything you need is included, at least for > IntelliJ. > YMMV when using those. If those are already outdated and those need an update, maybe it is a good point to introduce editorconfig [1]. The advantage of editorconfig is that you have one config file for "all" IDEs. That would decrease the maintenance effort. You can also generate it from your checkstyle config file. > There is a lot which could be done. > E.g. updating those files, some general code guidelines (like: do not use > guard statements, rather use an else), etc., when (not) to use Optionals, > when to use which Logger, when to keep compatibility to Java 7/8 for plugin > x/y… Yes, that is the main pain point! > But speaking about code style: I saw Christian (junit) using a > fmt-maven-plugin [1]. > That would be helpful, too, unless checkstyle can do the same now. I have a look on it. It is great, if you follow the Google Coding style. You can't configure your own style. [1]: https://editorconfig.org/ Am 22.12.20 um 17:00 schrieb Benjamin Marwell: > Hi Anders, > > those are outdated – not everything you need is included, at least for > IntelliJ. > YMMV when using those. > > There is a lot which could be done. > E.g. updating those files, some general code guidelines (like: do not use > guard statements, rather use an else), etc., when (not) to use Optionals, > when to use which Logger, when to keep compatibility to Java 7/8 for plugin > x/y… > > It is not just about code style! > > But speaking about code style: I saw Christian (junit) using a > fmt-maven-plugin [1]. > That would be helpful, too, unless checkstyle can do the same now. > > [1]: > https://github.com/sormuras/junit-platform-maven-plugin/blob/master/pom.xml#L294-L314 > > Am Di., 22. Dez. 2020 um 14:51 Uhr schrieb Anders Hammar >> : > >> There are settings files here: >> http://maven.apache.org/developers/conventions/code.html >> >> /Anders >> >> On Tue, Dec 22, 2020 at 2:47 PM Gary Gregory >> wrote: >> >>> It would be great if one could download Eclipse or Idea settings files, >> or >>> better yet, include them in each repo. >>> >>> Gary >>> >>> On Tue, Dec 22, 2020, 08:34 Sandra Parsick wrote: >>> >>>> Hello dev-list, >>>> >>>> some weeks ago, I have started creating some Pull Requests for the >> Maven >>>> JLink Plugin [1]. There were many hints about coding rules or decision >>>> which version / libs etc should be used and more. So I need some >>>> iterations till a trivial (IMHO) PR was accepted or in one case to find >>>> out the PR was completely unnecessary. That was a little bit >> frustating. >>>> I think it would be easier for new contributor to have a guideline or >>>> checklist of things to consider. I would love to help create such a >>>> checklist or guideline to lower the barrier to entry for contributing. >> I >>>> already discuss the idea with Ben and he has agreed to help. So what do >>>> you think about this idea? If this idea finds approval, where is the >>>> best place to place it? >>>> >>>> Best regards, >>>> >>>> Sandra >>>> >>>> [1] >>>> >>>> >>> >> https://github.com/apache/maven-jlink-plugin/pulls?q=is%3Apr+is%3Aclosed+author%3Asparsick >>>> >>>> >>> >> >
