Hi Ivan,

Basically the process is simple.
You should fork the master to your branch named, e.g. MRESOLVER-7.

I think the process is not a big issue right now.
The big issue here is the analysis of the code and a proposed fix.

It would be fine to split the changes into several independent commits or
(branches if possible and necessary) upon the my hints in Jira:
1. root cause of hanging Maven and deadlock of thread-resources starvation,
2. problems with thread-unsafe classes,
3. overrided objects across threads,
4. one unclear part in the algorithm

The ideal would be to isolate these four however it is a theory and still
keep the build success.

You should step into 1 at first, start the code analysis, understand the
problem with resource starvation and propose a fix or alternatives in a
comment. Then we would make a decision together.
Then the code will be changed and the community should check it out by
integrating into Maven and ITs. We would be happy if we could not have any
regression in each step.

If we could isolate the work in 4 or more fixes and Jira tickets, we would
have an easier life to bisect the commits and verify them separately while
we are in troubles in the future.

T









On Sat, Oct 16, 2021 at 5:21 PM Ivan Babiankou <ivan.babian...@gmail.com>
wrote:

> I would love to prepare decent PR
> <https://issues.apache.org/jira/browse/MRESOLVER-7?focusedCommentId=17171271&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17171271>
> for the MRESOLVER-7 issue, so that it makes it to one of the upcoming
> releases. But I could definitely use some guidance, given the history of
> the ticket
> <https://issues.apache.org/jira/browse/MRESOLVER-7?focusedCommentId=16885618&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16885618>
> and the fact that it’s my first contribution to Maven and OSS in general.
> Is there anyone willing to point me in the right direction (in email or a
> quick 15-30min call)?  I would really appreciate it.
>
> For now I’m reading the general things about contributing to Maven and
> looking at the old branch that was merged and then reverted.
>
>
> I see the master branch of Maven Resolver corresponds to v1.7.x, which
> requires Maven 4, however I would love to target the current Maven 3.x.
> Where should I start my PR off master or  maven-resolver-1.6.x?
>
> Thanks,
> Ivan
>
>
>

Reply via email to