michael-o commented on a change in pull request #8:
URL: https://github.com/apache/maven-reporting-exec/pull/8#discussion_r790856638
##########
File path: pom.xml
##########
@@ -191,35 +171,11 @@
<version>${mavenVersion}</version>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.sonatype.aether</groupId>
- <artifactId>aether-connector-wagon</artifactId>
- <version>1.7</version>
- <scope>test</scope>
- <exclusions>
- <exclusion>
- <groupId>org.codehaus.plexus</groupId>
- <artifactId>plexus-container-default</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
- <dependency>
- <groupId>org.apache.maven.wagon</groupId>
- <artifactId>wagon-http-lightweight</artifactId>
- <version>1.0</version>
- <scope>test</scope>
- <exclusions>
- <exclusion>
- <groupId>org.codehaus.plexus</groupId>
- <artifactId>plexus-container-default</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
<dependency>
<groupId>org.apache.maven.doxia</groupId>
<artifactId>doxia-site-renderer</artifactId>
- <version>1.1.4</version>
+ <version>1.10</version>
Review comment:
Drop this, it laready in the works with a separate ticket.
##########
File path:
src/main/java/org/apache/maven/reporting/exec/DefaultMavenPluginManagerHelper.java
##########
@@ -135,45 +62,15 @@ public PluginDescriptor getPluginDescriptor( Plugin
plugin, MavenSession session
{
try
{
- Object repositorySession = getRepositorySession.invoke( session );
- List<?> remoteRepositories =
session.getCurrentProject().getRemotePluginRepositories();
+ RepositorySystemSession repositorySystemSession =
session.getRepositorySession();
+ List<RemoteRepository> remoteRepositories =
session.getCurrentProject().getRemotePluginRepositories();
- return (PluginDescriptor) getPluginDescriptor.invoke(
mavenPluginManager, plugin, remoteRepositories,
-
repositorySession );
+ return mavenPluginManager.getPluginDescriptor( plugin,
remoteRepositories, repositorySystemSession );
}
catch ( IllegalArgumentException e )
{
logger.warn( "IllegalArgumentException during
MavenPluginManager.getPluginDescriptor() call", e );
Review comment:
Why skip this exceeption?
##########
File path:
src/test/java/org/apache/maven/reporting/exec/TestDefaultMavenReportExecutor.java
##########
@@ -64,6 +66,12 @@
public class TestDefaultMavenReportExecutor
extends PlexusTestCase
{
+ @Override
+ protected void customizeContainerConfiguration( @SuppressWarnings(
"unused" ) final ContainerConfiguration configuration )
+ {
+ super.customizeContainerConfiguration(configuration);
+
configuration.setAutoWiring(true).setClassPathScanning(PlexusConstants.SCANNING_CACHE);
Review comment:
add whitespace in both lines
##########
File path:
src/main/java/org/apache/maven/reporting/exec/DefaultMavenPluginManagerHelper.java
##########
@@ -186,37 +83,12 @@ public void setupPluginRealm( PluginDescriptor
pluginDescriptor, MavenSession se
{
try
{
- setupPluginRealm.invoke( mavenPluginManager, pluginDescriptor,
session, parent, imports,
- createExclusionsDependencyFilter(
excludeArtifactIds ) );
+ mavenPluginManager.setupPluginRealm(
+ pluginDescriptor, session, parent, imports,
createExclusionsDependencyFilter( excludeArtifactIds ) );
}
catch ( IllegalArgumentException e )
{
logger.warn( "IllegalArgumentException during
MavenPluginManager.setupPluginRealm() call", e );
Review comment:
Same here..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
