michael-o commented on a change in pull request #8: URL: https://github.com/apache/maven-reporting-exec/pull/8#discussion_r790882697
########## File path: src/main/java/org/apache/maven/reporting/exec/DefaultMavenPluginManagerHelper.java ########## @@ -186,37 +83,12 @@ public void setupPluginRealm( PluginDescriptor pluginDescriptor, MavenSession se { try { - setupPluginRealm.invoke( mavenPluginManager, pluginDescriptor, session, parent, imports, - createExclusionsDependencyFilter( excludeArtifactIds ) ); + mavenPluginManager.setupPluginRealm( + pluginDescriptor, session, parent, imports, createExclusionsDependencyFilter( excludeArtifactIds ) ); } catch ( IllegalArgumentException e ) { logger.warn( "IllegalArgumentException during MavenPluginManager.setupPluginRealm() call", e ); Review comment: same here ########## File path: src/main/java/org/apache/maven/reporting/exec/DefaultMavenPluginManagerHelper.java ########## @@ -135,45 +62,15 @@ public PluginDescriptor getPluginDescriptor( Plugin plugin, MavenSession session { try { - Object repositorySession = getRepositorySession.invoke( session ); - List<?> remoteRepositories = session.getCurrentProject().getRemotePluginRepositories(); + RepositorySystemSession repositorySystemSession = session.getRepositorySession(); + List<RemoteRepository> remoteRepositories = session.getCurrentProject().getRemotePluginRepositories(); - return (PluginDescriptor) getPluginDescriptor.invoke( mavenPluginManager, plugin, remoteRepositories, - repositorySession ); + return mavenPluginManager.getPluginDescriptor( plugin, remoteRepositories, repositorySystemSession ); } catch ( IllegalArgumentException e ) { logger.warn( "IllegalArgumentException during MavenPluginManager.getPluginDescriptor() call", e ); Review comment: I see no reason to log this since it will bubble up anyway... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org